[GLASSFISH-11637] INFO, WARNING and SEVERE messages need to be in property files, and have unique IDs Created: 02/Mar/10  Updated: 11/Feb/13  Resolved: 11/Feb/13

Status: Closed
Project: glassfish
Component/s: logging
Affects Version/s: 3.1
Fix Version/s: not determined

Type: Task Priority: Major
Reporter: Dies Koper Assignee: naman_mehta
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issuezilla Id: 11,637

 Description   

Up to GF V3 there was a requirement for messages to be put in message files for
internationalization, and for WARNING and SEVERE messages to have a unique ID.

In V3.1 a requirement has been added to give INFO messages unique IDs as well:

http://wiki.glassfish.java.net/Wiki.jsp?page=GlassFishV3LoggingMessageFormat

Unfortunately, so far these requirements haven't been enforced so many messages
are hard-coded in source or have no IDs.

Carla and I are working on identifying the issues with fixing this.
I'm creating this issue to track our changes to source for this in a single
place.
Although I selecting "logging" as the subcomponent, the changes will likely
cover all components.



 Comments   
Comment by Dies Koper [ 01/May/10 ]

Incremental fixes:

Sending
deployment\common\src\main\resources\com\sun\logging\enterprise\system\tools\deployment\LogStrings.properties
Transmitting file data .
Committed revision 36701.

Sending
transaction\jta\src\main\java\com\sun\enterprise\transaction\JavaEETransactionManagerSimplified.java
Sending
transaction\jta\src\main\resources\com\sun\enterprise\transaction\LogStrings.properties
Transmitting file data ..
Committed revision 36702.

Sending
appclient\client\acc\src\main\resources\org\glassfish\appclient\client\acc\LogStrings.properties
Transmitting file data .
Committed revision 36703.

Comment by Nithya Ramakrishnan [ 03/May/10 ]

Added the ID's and diagnostic description for the security related messages in ejb/ejb-container:

v3/ejb/ejb-
container/src/main/resources/com/sun/logging/enterprise/system/container/ejb/LogStrings.properties

Comment by Dies Koper [ 03/May/10 ]

Removed unused JDBC messages:

Sending
jdbc\jdbc-ra\jdbc-core\src\main\resources\com\sun\gjc\spi\LogStrings.properties
Transmitting file data .
Committed revision 36709.

Comment by Dies Koper [ 04/May/10 ]

Extracted web messages and added Ids for messages logged during QL.

Sending
web\war-util\src\main\resources\com\sun\logging\enterprise\system\container\web\LogStrings.properties
Sending web\web-glue\src\main\java\com\sun\enterprise\web\WebApplication.java
Sending web\web-glue\src\main\java\com\sun\enterprise\web\WebContainer.java
Transmitting file data ...
Committed revision 36742.

Comment by Dies Koper [ 10/May/10 ]

Fixed warning messages in Connector's LogStrings.properties which didn't have
Id's and diag info yet:

Sending connectors\connectors-inbound-
runtime\src\main\resources\com\sun\enterprise\connectors\inbound\LogStrings.prop
ertie
s
Sending connectors\connectors-
runtime\src\main\resources\com\sun\logging\enterprise\resource\resourceadapter\L
ogStrings.pro
perties
Transmitting file data ..
Committed revision 36878.

Comment by Tom Mueller [ 06/Mar/12 ]

Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

Generated at Thu Mar 05 10:40:07 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.