[GLASSFISH-1171] Make ddl generation default mode consistent Created: 20/Sep/06  Updated: 06/Mar/12

Status: Open
Project: glassfish
Component/s: entity-persistence
Affects Version/s: 9.0pe
Fix Version/s: not determined

Type: Bug Priority: Minor
Reporter: tware Assignee: tware
Resolution: Unresolved Votes: 4
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: All
Platform: All

Issue Links:
depends on GLASSFISH-1172 Java2DB: Properties need to be passed... Resolved
blocks GLASSFISH-1050 Java2DB on Java SE: FileNotFoundExcep... Open
Issuezilla Id: 1,171
Status Whiteboard:



Currently TopLink's ddlGeneration mode is different when running with
createEntityManagerFactory than it is for createContinerEntityManagerFactory.


This default mode was set in the early days of the GlassFish integration before
the createContainerEntityManagerFactory(PersistenceUnitInfo info, Map
properties) had a map of properties available.

When running with createEntityManagerFactory() we override the default by
setting an inSEMode flag and when running in SE mode, we effectively use:

We need to remove the inSEMode flag and always use the setting provided to

We should also change the default to: DDL_DATABASE_GENERATION since this will
allow most users to work by default.

In order for GlassFish DDL generation to continue to work, GlassFish will have
to pass the toplink.ddl-generation.output-mode=sql-script to the properties map
provided in createContainerEntityManagerFactory(). A separate bug will be
filed for that issue and it will be linked to this one.

Comment by tware [ 20/Sep/06 ]

Forgot to set to NEW

This is a bug rather than an enhancement becausse the current way it works is
very confusing.

Comment by tware [ 20/Sep/06 ]

added dependancy

Comment by tware [ 20/Sep/06 ]

depends on issue 1172

Comment by sherryshen [ 29/Sep/06 ]

add myself to cc

Comment by ijuma [ 02/Nov/06 ]

Adding myself to cc list.

Comment by bpasero [ 02/Nov/06 ]

adding myself to cc

Comment by pkrogh [ 08/Mar/07 ]

Reprioritized based on BUG triage. P4 HIGH.

Comment by Tom Mueller [ 06/Mar/12 ]

Bulk change to set fix version to "not determined" where the issue is open but the value is for a released version.

Generated at Fri Mar 06 13:50:15 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.