[GLASSFISH-12264] [Release Note]Samples. at ant all output was seen URL for samples that don't have a web client Created: 15/Jun/10  Updated: 06/Mar/12

Status: Open
Project: glassfish
Component/s: sample_apps
Affects Version/s: v3.0.1
Fix Version/s: not determined

Type: Bug Priority: Major
Reporter: easarina Assignee: scatari
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Windows Vista
Platform: All


Issuezilla Id: 12,264
Tags: 3_1-exclude, 3_1-release-note-added, 3_1-release-notes

 Description   

OS: Solaris Sparc, build: SDK build 21. Samples.
At the output from "ant all" for many apps that don't have a web client at all,
for example criteriaQuery or hello-jaxws2.2, was seen URL under deploy-url-
message. i.e. "Application deployed at htt://localhost:8080/... "

I think that users should not see such misleading messages



 Comments   
Comment by scatari [ 11/Oct/10 ]

The top level app-server-ant.xml that does the "deploy" of applications blindly calls this target that
displays the message "Application deployed at <URL>".

The fix would be to display this message only when the sample has an accessible web client URL. This
would require identifying such samples as part of the individual sample build system through setting a
flag, something like "hasWebURL=true/false".

Better yet do not display anything for now even for the applications that can be accessed through web.
Anyhow, the URLs are part of the sample docs.

Comment by scatari [ 11/Oct/10 ]

<exec executable="$

{asadmin}

" failonerror="$

{failonerror}

">
<arg line=" deploy "/>
<arg line=" --user $

{javaee.server.username}

" />
<arg line=" --passwordfile '$

{javaee.server.passwordfile}

'" />
<arg line=" --host $

{javaee.server.name}

" />
<arg line=" --port $

{javaee.adminserver.port}

" />
<arg line=" --name $

{module.name}

"/>
<arg line=" --force=true "/>
<arg line=" --upload=true "/>
<arg line=" --dbvendorname $

{db.vendorname}

"/>
<arg line=" --property compatibility=v2"/>
<arg line="$

{app.module}

" />
</exec>
<antcall target="deploy-url-message"/>
</target>

<target name="deploy-url-message" if="app.url">
<echo message="Application Deployed at: $

{app.url}

"/>
</target>

Comment by scatari [ 12/Oct/10 ]

This would need fix across samples, targeting for 3.2. Will have to Release Note considering the less
impact on users, transferring to Doc.

Scott,
Please assign as appropriate.

Comment by Paul Davies [ 13/Oct/10 ]

Added 3.1-release-notes to indicate the issue should be documented in the
Release Notes.

Reset the subcomponent to sample_apps to enable any possible future code fix to
be tracked.

Comment by Paul Davies [ 13/Oct/10 ]

Reassigned to owner of selected subcomponent. No need to assign it to the RN
writer, as the 3.1-release-notes keyword indicates that this issue is to be
documented in the RN.

Comment by Nazrul [ 20/Dec/10 ]

Will be release noted by documentation team. Excluding from 3.1 bug count.

Comment by Scott Fordin [ 23/Mar/11 ]

Need more info to add issue to 3.1 Release Notes.

Comment by easarina [ 28/Mar/11 ]

I did not try to run this test against latest builds. But the general idea, for apps that don't have a web client, users have to ignore this message and don't use the URL.

Comment by Scott Fordin [ 13/Apr/11 ]

Added issue to 3.1 Release Notes.

Comment by Tom Mueller [ 06/Mar/12 ]

Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

Generated at Sun Sep 25 01:13:53 UTC 2016 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.