|<< Back to previous view|
[GLASSFISH-15289] Regression in create instance and a better error message needed Created: 20/Dec/10 Updated: 22/Mar/13 Resolved: 22/Mar/13
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Participants:||Anissa Lam, carlavmott and lidiam|
In Admin Console create a CONFIG type node filling out the required fields only. Go to Standalone Instances page and click new. Attempt to create an instance using the newly created node and the following error is displayed:
An error has occurred
The above used to work in earlier builds. If this regression cannot be fixed, we should at least tailor the error message towards the Admin Console users, since that's where it is displayed and tell them how to fix the problem in Admin Console alone (CLI information can be present additionally, if desired).
|Comment by carlavmott [ 21/Dec/10 11:18 AM ]|
The nodehost is required and will continue to be. There are scenarios where the nodehost is required and there is no way to make this option required in some cases and optional in others so it will be required.
Not sure what to do about messages. It is the cli command that is running (from the console) so the message is specific for cli users. If we tailor the message for console then it doesn't make sense for cli users. This is a problem that affects several messages in the cli commands.
|Comment by carlavmott [ 21/Dec/10 02:53 PM ]|
this is not a regression and nodehost will be required.
Assigning to Anissa because the cli should not change the message so it is suitable for the console. The console will have to come up with a suitable message.
|Comment by Anissa Lam [ 21/Dec/10 03:49 PM ]|
GUI cannot analysis what error message says and thus there is no way for GUI to 'replace' or 'add' any info to display to user.
As for whether the 'nodeHost' should be a required field in GUI or not, this has been changing back and forth couple times. The last I heard from Joe is we should NOT require that since it will affect other user case.
Email from Joe on 12/20/2010 9:20AM says:
Anissa Lam wrote:
There are two use cases. One use case does not require the fields. The
If you are going to create the instance with create-local-instance
If you are going to do offline config with create-instance then the
I would not change the GUI to require them since that impacts
So, no more change in GUI
|Comment by Anissa Lam [ 21/Dec/10 03:50 PM ]|
btw, GUI screen also matches what CLI required:
Usage: asadmin [asadmin-utility-options] create-node-config
|Comment by carlavmott [ 21/Dec/10 04:00 PM ]|
Taking the issues separately.
nodehost is required for the offline case and I believe that what Joe is saying is that he is not comfortable changing that. So nodehost will also be required. The GUI and the cli stay as they are. I believe this part of the issue is closed in that no change will be made.
That leaves the message part. If the admin gui does not change the message or can not then I will suggest that we do not change it for the cli since there are several places this message and similar messages are created and our only option is to create a message that is very generic. So it will not tell the user to run a command and it will not tell them to go to a specific screen. I think it is too late to try and fix the messages since testing involves making sure we hit all the error cases and in the pat this has taken a lot of time. I will defer til 3.2
|Comment by Anissa Lam [ 21/Dec/10 04:31 PM ]|
However, when i save a CONFIG node, I am getting the error:
and when i use CLI, I get error as well.
%v3admin update-node-config dummy-config
So, backend is enforcing the requirement of nodehost when both CLI and GUI is telling user this is optional.
You need to remove the requirement of nodehost. otherwise, both CLI and GUI user runs into error everytime.
I am removing the 3.1_exclude tag. Please at least fix this part.
|Comment by lidiam [ 21/Dec/10 04:44 PM ]|
There is another scenario with fields that are not marked as required but need to be specified when creating an instance. I create a CONFIG node specifying localhost for host name and leaving other fields blank. I then attempt to create an instance under such node from Admin Console but it fails due to the following error:
An error has occurred
This will be confusing to users. I hope we can default installation directory for CONFIG node if the host is localhost. Please let me know if this should be logged as a separate issue.
This used to work in earlier builds, when Installation Directory was defaulted for CONFIG nodes.
|Comment by carlavmott [ 21/Dec/10 05:06 PM ]|
Yes, things have changed and some changes were a result of Arch review and some were because validation was added for the offline scenario case.
I take Joe's response to mean that we are not changing the back end because it is too risky but he doesn't see an issue with leaving the GUI screen as it is. Right now both nodehost and installdir are required but the underlying code even though in some cases it really is not necessary because we can figure out the value.
I'm going to exclude this bug from 3.1 because we will not change the backend code.
|Comment by carlavmott [ 19/Jan/11 03:52 PM ]|
The scenario in this test was really not handled in 3.1. For 3.2 release I have added support to allow create-instance to create the instance config element when the node element doesn't have the nodehost or the installdir specified. The user will have to run create-local-instance to create the instance file system and that will also update the node element with the nodehost and installdir information. All other references to that node will also inherit the nodehost and installdir.
This scenario is closest to what was supported in GlassFish v2 where the node agent provided the information at instance creation time if it didn't exist. See scenario 8 on the Instance Lifecycle Scenarios wiki page http://wikis.sun.com/display/GlassFish/3.1SSHScenarios
|Comment by carlavmott [ 02/Feb/11 09:06 PM ]|
nodehost and installdir no longer required when creating a config node
Committed revision 44848.
Still need to work on error message
|Comment by carlavmott [ 16/Feb/13 12:40 AM ]|
O plan to fix this for EE7 release. The only thing to do is to update the error message to include information on how to proceed in the GUI and don't plan on removing the instructions for the CLI. This fix will impact testing since they will need to verify.
|Comment by carlavmott [ 22/Mar/13 11:22 PM ]|
I can not recreate this error condition as behavior has changed and the error message that was in question is no longer printed. Therefore I have nothing to change.