[GLASSFISH-17366] Log lines consume a lot of time. Created: 28/Sep/11  Updated: 22/Oct/12  Resolved: 22/Oct/12

Status: Resolved
Project: glassfish
Component/s: cdi
Affects Version/s: 3.1.1
Fix Version/s: 4.0_b64_EE7MS2

Type: Improvement Priority: Major
Reporter: thomas.giger Assignee: jjsnyder83
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows XP


Tags: weld-integration

 Description   

We have an application that consists of a couple of CDI bean modules. I noticed that the time to redeploy could be reduced singnificantly by removing some trace lines in the weld-integration.jar (in my case from 54 to 19 seconds)

The lines are:
BeanDeploymentArchiveImpl.java

  • getBeanClasses()
    • logger.log(FINER, "set TCL for " + this.id + " to " + this.moduleClassLoaderForBDA);

and
DeplyomentAcrhiveImpl.java

  • getBeanDeploymentArchives(boolean printDebug) {
    • if (printDebug) logger.log(FINE, "DeploymentImpl::getBDAs. " +
      "Returning \n" + beanDeploymentArchives);

It seemed strange to me. May be you can have a look into this.



 Comments   
Comment by Sivakumar Thyagarajan [ 15/Oct/12 ]

Will investigate and fix this in 4.0. Exact build TBD.

Comment by Tom Mueller [ 17/Oct/12 ]

Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.

Comment by jjsnyder83 [ 22/Oct/12 ]

Added checks on the log level so Strings aren't built unnecessarily.

Committed revision 56679

Generated at Sun Jul 05 22:00:31 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.