[GLASSFISH-18423] JMS: Inspect JDK 7 getMethods()/getDeclaredMethods() usage Created: 28/Feb/12  Updated: 29/Feb/12  Resolved: 29/Feb/12

Status: Closed
Project: glassfish
Component/s: jms
Affects Version/s: 4.0_b25
Fix Version/s: 4.0_b25

Type: Task Priority: Major
Reporter: Joe Di Pol Assignee: David Zhao
Resolution: Works as designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


Recent JDK 7 releases have altered the order of methods returned by the
Class.getMethods() and Class.getDeclaredMethods() calls. The order is
no longer stable and can change from one JVM run to the next.

This caused a number of sporadic bugs to appear during 3.1.2 development
when running with JDK 7. Those have been fixed, but further inspection
of the source has found a number of cases where we use getMethods() and

Each of these cases should be visually inspected to see if the code is
making any assumptions on the order of methods returned by get*Methods().
In particular it should handle the case of multiple methods having the
same name.

For more details on what to look for and how to fix it see this document:


Please inspect the following files for their use of getMethods() /
getDeclaredMethods() to ensure the code is not making any assumptions
with respect to the order of methods returned. Create bugs for
any issues that need to be fixed and link them to this task. Once you
have completed inspection update this task with status and close it.

JMS admin

Comment by David Zhao [ 29/Feb/12 ]

In JMSDestination class, it invokes MQ's ResourceAdapter.getJMXConnectorEnv() and ResourceAdapter.getJMXServiceURLList() by feflection. The methods are matched by name during going through all methods returned by ResourceAdapter.class.getMethods(). It would be still safe with JDK7 for the methods are not overloaded in ResourceAdaper - only the expected methods can be matched and it is order irrelevant for now.

Generated at Fri Nov 27 15:18:50 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.