[GLASSFISH-18584] "description" elements in glassfish-resources.xml not moved to "description" fields in domain.xml Created: 31/Mar/12  Updated: 07/Jan/13

Status: Open
Project: glassfish
Component/s: jca
Affects Version/s: 3.1.1, 3.1.2
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: fishcream Assignee: naman_mehta
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

All


Tags: configuration, description, glassfish-resources, resources

 Description   

For application/module resources files (glassfish-resources.xml) located in either the "META-INF" or "WEB-INF" directories of war, ear, or ejb projects, the DTD at:
http://glassfish.org/dtds/glassfish-resources_1_5.dtd

Specifies that the "description" must be a subelement of many of the elements (not an attribute). Specifically the "property" element has a description subelement possible.

However, the domain.xml file requires that the description be an attribute. This relates to issue GLASSFISH-16630 which is marked as "Won't fix". If we accept that we will not fix this because it causes problems migrating configuration from glassfish 2.x to 3.x, then at least when a project is deployed that has application/module resources, the "description" element should be copied into the "description" attribute.

One of the great benefits of the new portable JNDI namespaces and application resource files, you can now modify an application/module resource inside the of the Glassfish Admin site without redeploying or packaging the application. However, it gets very confusing when your configuration properties do not have a description associated with them.



 Comments   
Comment by Tom Mueller [ 24/Dec/12 ]

This appears to be deployment related, so assigning to the deployment category.

Comment by Hong Zhang [ 26/Dec/12 ]

The resource team owns glassfish-resources.xml, assign to Jagadish for evaluation

Comment by Jagadish [ 04/Jan/13 ]

Transferring to Naman for investigation.
It looks like we do seem to handle "description" element of glassfish-resources.xml for jdbc resource but not for other resource types.

Comment by naman_mehta [ 07/Jan/13 ]

I tried on the latest workspace and this bug is not reproducible. I can find description is mapped to domain.xml.

e.g.

<jdbc-resource pool-name="java:app/TestPool" description="This is the default pool." jndi-name="java:app/jdbc/TestDB"></jdbc-resource>
<mail-resource host="localhost" description="This is the mail resorce." jndi-name="java:app/mail/csjdb1" from="xtecuan@gmail.com" user="xtecuan"></mail-resource>

I am attaching the sample .war file with test code. Just try to deploy the same and verify this bug.

Comment by naman_mehta [ 07/Jan/13 ]

Couldn't find option for attachment here so sent as separate email.

Generated at Sun Apr 26 10:20:11 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.