Add support CDI in plain OSGi bundles
[GLASSFISH-19346] Adding fighterfish test cases Created: 14/Nov/12 Updated: 10/Dec/12
|Affects Version/s:||future release|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Attachments:||GLASSFISH-19215_fighterfishtestcase_20121114.zip GLASSFISH-19215_fighterfishtestcase_final.zip GLASSFISH-19215_fighterfishtestcase_multi-interfaces.zip|
According to sahoo's test requirements , adding fighterfish test cases. In addition,
1) also needing to add negative test like failing to inject myservice as a regular cdi bean.
|Comment by TangYong [ 14/Nov/12 ]|
Hi sahoo, siva,
|Comment by TangYong [ 15/Nov/12 ]|
Please try the attachment.
|Comment by Sivakumar Thyagarajan [ 23/Nov/12 ]|
The test cases looks good. I will try it out once I have your patch integrated locally into my workspace. The only enhancement I would like to see is that both the tests uses the "contracts" annotations attribute in @OSGiService, but do not use to add any new meaning, and just set the only interface that the Bean is implementing as the "contracts" value. It would be nice if we have another test or just reuse the 2 new test you have added, where the test tries to choose from one interface from a set of interfaces a Bean implements, and then testing to make sure that BarBean is available as an OSGiService only through Bar.class and not through Baz.class
In the test Servlet:
|Comment by TangYong [ 24/Nov/12 ]|
Thanks your suggestion very much. I have understood your means and I will add test for multi-interface scene.
|Comment by TangYong [ 27/Nov/12 ]|
I have attached a new test case(GLASSFISH-19215_fighterfishtestcase_multi-interfaces.zip) for testing multi interfaces, and please seeing it.
|Comment by TangYong [ 10/Dec/12 ]|
Because osgi-cdi-api will have some changes which are from Siva's suggestions, fighterfish tests will also make some changes. Waiting for final API Release.