[GLASSFISH-20102] Samples: Inspect projects with <packaging>pom</packaging> so their <modules> accurately reflects the intent Created: 29/Mar/13  Updated: 02/May/13  Resolved: 02/May/13

Status: Resolved
Project: glassfish
Component/s: sample_apps
Affects Version/s: None
Fix Version/s: 4.0_b87_RC3

Type: Bug Priority: Critical
Reporter: Ed Burns Assignee: Snjezana Sevo-Zenzerovic
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

I have discovered one case where the <packaging>pom<packaging> that directs the flow of the build is missing entries in its <modules> section that apparently should be included.

This one instance is the jsf/pom.xml. I'll work with the engineers who contributed those samples to ensure they are wired up and do not break the build, but this brings to my attention the possibility for other instances of this problem.

I think a manual inspection is in order.



 Comments   
Comment by Snjezana Sevo-Zenzerovic [ 02/Apr/13 ]

This is more of a task than a bug, but I'll leave it as is so that it stays on the current dashboard. We do need to review sample application pom files, both for the correct module list and also for dependencies.

Comment by shreedhar_ganapathy [ 19/Apr/13 ]

Hi Snjezana, Ed
Was there any further progress on this task?
Hopefully this is limited only to the jsf and no other modules.

Comment by Snjezana Sevo-Zenzerovic [ 24/Apr/13 ]

I am planning to use this bug to cover overall review and sanity check on Java EE 7 samples workspace pom files. This will cover items such as dependency usage, hard-coded plugin and dependency versions and module list check.

Comment by Snjezana Sevo-Zenzerovic [ 02/May/13 ]

POM review has been completed. I checked in all trivial changes:

  • Fixed all pom.xml files to use consistent EOLs (quite a few contained the mix of Windows and Unix style EOL characters).
  • Removed references to java.net repository definition which is now consolidated in top level pom.xml
  • Removed explicit versions for managed plugin references.
  • Introduced glassfish.version property which can be used to reference GlassFish promoted build artifacts.
  • Removed javaee7/rest/tictactoe sample from the default reactor since it requires manual installation of JavaFX dependency prior to building.

I also filed following issue to resolve questionable EJB sample gf-client dependency: GLASSFISH-20454.

Generated at Tue Dec 06 18:49:25 UTC 2016 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.