[GLASSFISH-2117] thread-unsafe code in com.sun.enterprise.server.logging.ServerLogManager Created: 19/Jan/07  Updated: 06/Mar/12

Status: Open
Project: glassfish
Component/s: logging
Affects Version/s: 9.1pe
Fix Version/s: not determined

Type: Bug Priority: Minor
Reporter: llc Assignee: jielin
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: All
Platform: All

Issuezilla Id: 2,117


The variables 'customHandler' and 'customFilter' are not synchronized or volatile, leading to visibility
and/or race condition issues. With both of them being used, any synchronization has to surround the
paired usage:

private static Handler customHandler = null;
private static Filter customFilter = null;

private static Filter getCustomFilter( ) {
if(( customFilter != null )

( customFilterError ) ) { return customFilter; }

LogService logService = getLogService( );
if( logService == null )

{ return null; }

String customFilterClassName = null;

{ customFilterClassName = logService.getLogFilter( ); customFilter = (Filter) getInstance( customFilterClassName ); }

catch( Exception e )

{ customFilterError = true; new ErrorManager().error( "Error In Instantiating Custom Filter " + customFilterClassName, e, ErrorManager.GENERIC_FAILURE ); }

return customFilter;

Comment by gfbugbridge [ 20/Jan/07 ]


Comment by sridatta [ 22/Jan/07 ]

will be fixed for FCS.Downgrading to a P3.

Comment by jielin [ 06/Mar/07 ]

They are not reaaly bugs. Will not fix at this time frame.

Comment by llc [ 06/Mar/07 ]

You're claiming they're thread safe?

Or that they're not thread safe, but somehow called in a way that is thread safe?

If "they won't be fixed at this time", then that presumes there is something to fix, so how can they "not be

Comment by dpatil [ 11/Apr/07 ]


Comment by Tom Mueller [ 06/Mar/12 ]

Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

Generated at Tue Mar 28 18:31:36 UTC 2017 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.