[GLASSFISH-543] add field fields to 'Configuration->Http Service: Access Log tab' Created: 05/Apr/06  Updated: 06/Mar/12

Status: Open
Project: glassfish
Component/s: admin_gui
Affects Version/s: 9.0pe
Fix Version/s: not determined

Type: Improvement Priority: Critical
Reporter: vince kraemer Assignee: Anissa Lam
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: All
Platform: All

Attachments: Text File OLH-http-service.tiff    
Issuezilla Id: 543


See issue 541.

This seems like a good place to put fields to manipulate the accessLogBufferSize
and accessLogWriteInterval.

Folks want to manipulate these values, and they aren't available easily.

Comment by Anissa Lam [ 21/Feb/07 ]

I am ready to add this.
But i need input from Jan and JF whether this should be exposed to user as a
text field. In order word, do we prefer to hide this from user ?
If presenting this as a text field, what should be the default value for these 2
Please provide a one-sentence help to be put on the page for this field.

Comment by vince kraemer [ 11/Jul/07 ]

did this ever get commited?

Comment by Anissa Lam [ 11/Jul/07 ]

Sorry, this was put behind while waiting for the input from Jan & JF.
so, the answer is no.

Comment by vince kraemer [ 11/Jul/07 ]

Ok. one more thing for v3...

Comment by Anissa Lam [ 24/Jul/07 ]

Kedar also request the following. (refer to issue#3398)

provide a "check-box" at both the http-service config page and virtual-server
config page? It is not a good idea to make users key-in or delete the property

Anissa, I would request you to provide a check-box for these elements. The
internals remain the same. Checked => setProperty("accessLoggingEnabled", "true")
and Unchecked => setProperty("accessLoggingEnabled", "false") and vice versa.

Comment by jluehe [ 24/Jul/07 ]

The access log buffer size (in bytes). A value <=0 disables buffering. Default: 4096

The interval (in seconds) between writing (updating) the access log. A value <=0
disables buffering. Default: 0

Comment by Anissa Lam [ 29/Jul/07 ]

The OLH of admin gui gives some default of the properties which doesn't match
with what Jan mentioned in previous comment.
Jan, if you press the 'Help' button on the upper right corner when looking at
the Http Service page, you will see that, please review it.
In case you don't have the GUI up, i have attached that table.
I have open up an issue for OLH change, it is issue# 3447.
You may want to update that issue instead to ensure the help content is correct.

Comment by Anissa Lam [ 29/Jul/07 ]

Created an attachment (id=1069)
OLH property table

Comment by jluehe [ 30/Jul/07 ]

Hi Anissa, the default values I mentioned are hard-coded in the code (more
specifically, in com.sun.enterprise.web.PEAccessLogValve in appserv-core), as
opposed to being exposed as default property values in domain.xml.

(This goes all the way back to a comment I made to June Parks, when I suggested
that we distinguish between default values and default settings in the admin

So, if access logging has been disabled, any values for "accessLogBufferSize" or
"accessLogWriteInterval", whether they be hard-coded or specified as properties
in domain.xml, will be ignored.

However, once you enable access logging, and don't specify any
"accessLogBufferSize" or "accessLogWriteInterval" properties, the default values
I mentioned will be picked up.

Comment by Tom Mueller [ 06/Mar/12 ]

Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

Generated at Sat May 30 23:11:06 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.