[JAVASERVERFACES-2244] UIInput and UIData create unnecessary state array Created: 13/Nov/11 Updated: 02/Nov/12 Resolved: 02/Aug/12
|Affects Version/s:||2.1.3, 2.1.4|
|Reporter:||arjan tijms||Assignee:||Manfred Riem|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
Similar to issue
The most obvious is UIInput:
Should become something like:
UIData is a little less obvious. It has a guard, but still calculates the super state twice and the part where the state has not been marked does suffer directly from the problem.
UIViewRoot has the guard now, but still defines values as an instance variable. In changeset 8600 Ed Burns had moved the same variable in UIInput to a local variable. It's perhaps better to do that here as well.
I've attached a patch against the mojarra trunk (2.2). All tests pass after the patch, although one test had to be modified (a test that checks the returned state array for attached state now has to test the entire array for null instead of the third element).
|Comment by arjan tijms [ 03/Dec/11 ]|
Some additional concern is that's it's maybe questionable if UIInput's emptyStringIsNull and validateEmptyFields should really be in view state? They seem to be global concerns and not a per component thing. Perhaps storing these in application scope is a better approach?
|Comment by Manfred Riem [ 02/Aug/12 ]|
Tracking as 2 separate issues
|Comment by Manfred Riem [ 03/Aug/12 ]|
Changes for UIInput are done