[JSR_333-71] mistakes in javadoc for Node#getNodes and Event#getMixinNodeTypes ? Created: 09/Jun/13  Updated: 02/Sep/13  Resolved: 20/Aug/13

Status: Resolved
Project: jsr-333
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: dbu Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

while working on JSR_333-59 i noticed two confusing things:

Node#getNodes(String[] nameGlobs, String[] typeGlobs)

how would typeGlobs work exactly? its not really globs, right? the doc says we do Node.isNodeType(T) but that method does not accept globs. i guess that second parameter is simple typeNames, right?

Event#getMixinNodeTypes (and also getPrimaryNodeType) do not list the PROPERTY_CHANGED event as being able to return this information. is this on purpose or an accident? if its on purpose, i propose to add something explaining why it should not work.



 Comments   
Comment by Peeter Piegaze [ 20/Aug/13 ]

You are right about the Event#getMixinTypes and Event#getPrimaryNodeType. They should both include explanations of what is returned when this Event is PROPERTY_CHANGED. I have fixed the javadoc.

Regarding the typeGlobs issue: For an accessible node N to be returned, the typeGlob string is required to match T where T is the name of a type that applies to N, and the nameGlob string is required to match C, where C is the name of N.

By "match" we mean "match by globbing", not "is equal to". I will clarify the language in the javadoc.

Comment by Peeter Piegaze [ 20/Aug/13 ]

fixed

Comment by dbu [ 02/Sep/13 ]

added to PHPCR in https://github.com/phpcr/phpcr/pull/72

Generated at Sun Mar 26 02:27:53 UTC 2017 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.