[PORTLETSPEC3-11] Create single interface to handle public and private render parameters Created: 03/May/13 Updated: 22/Jan/16 Resolved: 22/Jan/16
|Component/s:||Ideas for JSR 362 Extensions|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
The StateAwareResponse and BaseURL interfaces both allow setting and getting public and private render parameters.
|Comment by msnicklous [ 06/May/13 ]|
Updated the problem priority to "minor" from "major" ... corrected an oversight on my part.
|Comment by julien_viet [ 10/May/13 ]|
I don't see how that is technically possible since:
1/ StateAwareResponse class has methods named "render parameter" such as setRenderParameters(String key, String value)
2/ BaseURL class has methods named "parameter" such as setParameter(String name, String value)
|Comment by msnicklous [ 13/May/13 ]|
We would have to include both setRenderParameters and setParameters in the new interface, and deprecate one of them. The point is that the parameters don't really differ conceptually (at leaset as I understand it so far), so we shouldn't have two different method names for setting / getting the same thing.
|Comment by Neil Griffin [ 14/May/13 ]|
I like the idea of a separate interface very much, but perhaps it could be left as an implementation detail.
It might be that I am simply accustomed to the existing API, but it seems like:
seems to self-document a little better than:
meaning that the parameter is intended for the render request (in some sense).
|Comment by msnicklous [ 22/Jan/16 ]|