[SWINGX-1347] StringValues: add type which is UIResource Created: 15/Sep/10  Updated: 28/Jan/11  Resolved: 05/Nov/10

Status: Resolved
Project: swingx
Component/s: Renderer
Affects Version/s: 1.6.2
Fix Version/s: 1.6.3

Type: New Feature Priority: Major
Reporter: kleopatra Assignee: kleopatra
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issuezilla Id: 1,347

 Description   

StringValues can be used by a variety of clients. If installed by uiManagers, they should
implement UIResource to mark them as such. Add wrapper to StringValues zoo



 Comments   
Comment by kleopatra [ 15/Sep/10 ]

added StringValueUIResource which wraps around a given StringValue
added tests

Comment by Karl Schaefer [ 15/Sep/10 ]

Issue 1347: Updated DefaultsList to ensure that any SwingX supplied
StringValues are UIResources.

src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java

Committed revision 3785.

Comment by Karl Schaefer [ 15/Sep/10 ]

commit -m "Issue 1347: Updated DefaultsList to ensure that any SwingX supplied
StringValues are UIResources." C:/workspace/swingx/swingx-
core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java
Sending C:/workspace/swingx/swingx-
core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java
Transmitting file data ...
Committed revision 3785.

Comment by Karl Schaefer [ 15/Sep/10 ]

What if the wrapped StringValue is a MappedValue? Seems like that would fail
to provide the same results.

Comment by kleopatra [ 15/Sep/10 ]

oops ... good catches, both of your comments

Re-opening - no time to look into the MappedValue right now, but sure need to handle it,
darn, how could i forget that

Thanks
Jeanette

Comment by Karl Schaefer [ 15/Sep/10 ]

You could alter StringValueUIResource to be a MappedValue. I think that just
solves the issue.

Comment by kleopatra [ 05/Nov/10 ]

Decided to add a separate class MappedValueUIResource. Feels safer than unconditionally
extending the type of a plain StringValue by simply throwing it into the wrapper. Such
a type extension might come as a surprise for developers.

Plus the MappedValue is a ... ehem ... temporary clutch which survived Keeping that
separate from the base makes it easier to cleanup eventually (harhar - as if that would
ever happen <g>)

Generated at Sun May 01 13:08:23 UTC 2016 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.