[SWINGX-1472] Make RectanglePainter constructors consistent Created: 15/Nov/11  Updated: 15/Nov/11  Resolved: 15/Nov/11

Status: Resolved
Project: swingx
Component/s: Painter
Affects Version/s: 1.6.3
Fix Version/s: 1.6.3

Type: Bug Priority: Major
Reporter: brettryan Assignee: rah003
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 30 minutes
Time Spent: Not Specified
Original Estimate: 30 minutes

Attachments: Text File 0002-Corrected-constructor-to-match-overloaded-behaviour.patch    


RectanglePainter's overloaded constructor of the form RectanglePainter(int, int, int, int, int, int, boolean, Paint, float, Paint) is setting both horizontal and vertical fill properties to true which is not consistent with the other constructors, this in turn causes unit tests to fail.

Patch attached.

Comment by Karl Schaefer [ 15/Nov/11 ]

Actaully, I discovered this while fixing unit tests. The right thing is to make them consistant by determining the value of the supplied parameter and inferring the correct fill value.

Generated at Sun Apr 23 08:28:25 UTC 2017 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.