<< Back to previous view

[JAVAMONEY-12] Align Integration Requirements With OpenJDK Created: 30/Jan/13  Updated: 02/Mar/14  Due: 14/Mar/15

Status: Open
Project: javamoney
Component/s: Impl: RI
Affects Version/s: None
Fix Version/s: 0.9

Type: Task Priority: Minor
Reporter: atsticks Assignee: Unassigned
Resolution: Unresolved Votes: 0
Remaining Estimate: 2 days
Time Spent: Not Specified
Original Estimate: 2 days
Environment:

Targeting SE 9.


Tags: core JSR SE design
Participants: atsticks and keilw

 Description   

It is viable to discuss with Oracle JDK architects the required constraints on value type and accessor design. As a result of this task a small document should be written or provided that states the common requirements for SE JSRs like this. As an advantage this document can also be shared with other JSRs that are not lead by Oracle.



 Comments   
Comment by keilw [ 26/Apr/13 05:19 PM ]

Given Java 9 has been deferred to early 2016 this issue probably won't matter at all for 1.0





[JAVAMONEY-58] Currency data source URL for IsoCurrencyOnlineProvider needs updating Created: 12/Aug/13  Updated: 11/Mar/14

Status: In Progress
Project: javamoney
Component/s: Impl: RI
Affects Version/s: None
Fix Version/s: 0.8

Type: Bug Priority: Minor
Reporter: paulkmoore Assignee: keilw
Resolution: Unresolved Votes: 0
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags:
Participants: keilw and paulkmoore

 Description   

The URL which specifies the location of the currency source in net.java.javamoney.ri.ext.provider.iso.IsoCurrencyOnlineProvider#loadCurrencies method is no longer valid. The current source is:

http://www.currency-iso.org/dam/isocy/downloads/dl_iso_table_a1.xml

which results in an Http 404.

I believe the replacement should be:

http://www.currency-iso.org/dam/downloads/table_a1.xml


 Comments   
Comment by keilw [ 12/Aug/13 04:57 PM ]

As a first step I'm fixing the URL to the new version. Where CI server (Jenkins) would also allow us to run Integration Tests there should be some for external services such as this to flag whenever this or another URL changes in future.
Will externalize it into a properties file for easier maintenance, but ultimate customization should be possible similar to Java 7+ Currency class:
>Users can supersede the Java runtime currency data by creating a properties file named <JAVA_HOME>/lib/currency.properties. The contents of the properties file are key/value pairs of the ISO 3166 country codes and the ISO 4217 currency data >respectively. The value part consists of three ISO 4217 values of a currency, i.e., an alphabetic code, a numeric code, and a minor unit. Those three
>ISO 4217 values are separated by commas. The lines which start with '#'s are considered comment lines. For example,...

either we'd use this file or introduce another one or two additional files (not too many, otherwise it gets confusing and we'd have a Spring-like maze of properties

Comment by keilw [ 13/Aug/13 12:00 AM ]

Changed, those URLs are now loaded from a properties file, but neither of the URLs looks like it gets results from parsing
I suppose the 404 error was mainly a browser-based observation, so there may be something left to do.

Debug information (if log level is changed appropriately or System.out/IDE-debugging used) tells currencies is empty, while the list of countries contains 249 of them.

Comment by paulkmoore [ 13/Aug/13 09:12 AM ]

Werner, the mapping also appears to have changed - I guess they did this as part of the "move"...

From the comments in code the previous feed appears to be structured as follows:

// <ISO_CCY_CODES>
// <ISO_CURRENCY>
// <ENTITY>AFGHANISTAN</ENTITY>
// <CURRENCY>Afghani</CURRENCY>
// <ALPHABETIC_CODE>AFN</ALPHABETIC_CODE>
// <NUMERIC_CODE>971</NUMERIC_CODE>
// <MINOR_UNIT>2</MINOR_UNIT>
// </ISO_CURRENCY>
// ...
// </ISO_CCY_CODES>

Whereas the new feed is as follows:

<ISO_4217 Pblshd="">
	<CcyTbl>
		<CcyNtry>
			<CtryNm>AFGHANISTAN</CtryNm>
			<CcyNm>Afghani</CcyNm>
			<Ccy>AFN</Ccy>
			<CcyNbr>971</CcyNbr>
			<CcyMnrUnts>2</CcyMnrUnts>
		</CcyNtry>
		<!--snip-->
	</CcyTbl>
</ISO_4217>




Generated at Fri Apr 18 20:20:00 UTC 2014 using JIRA 4.0.2#472.