[GLASSFISH-17916] Additional property in Setting Tab can't be saved for Load Balancer Created: 07/Dec/11  Updated: 13/Dec/11  Resolved: 13/Dec/11

Status: Closed
Project: glassfish
Component/s: load_balancer
Affects Version/s: 3.1.2_b12
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: li.wu Assignee: srinik76
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Bundle: ogs-3.1.2-web-b12-unix-ml.sh
OS: OEL6 x64
Server Locale: zh_TW
Browser: firefox3.6
Browser Locale: ja_JP


Attachments: JPEG File add_property.jpg     JPEG File LB_property_saved.jpg    

 Description   

1. Install the bundle;
2. Create a new Load Balancer named "test" with Device Host as "localhost", Device Admin Port as "9090";
4. Click "test" and switch to Setting tab, click Add Property button and enter its Name,Value,Description, and then click Save button;
5. "New value successfully saved" showed, but nothing saved in fact.



 Comments   
Comment by kshitiz_saxena [ 07/Dec/11 ]

Assigning to admin console team

Comment by srinik76 [ 07/Dec/11 ]

Tried in the latest build 3.1.2 workspace in english locale. Not able to reproduce it works fine.

Comment by li.wu [ 08/Dec/11 ]

Fixed in 3.1.2_b13

Comment by srinik76 [ 13/Dec/11 ]

Reopening to add fix version to 3.1.2_b13





[GLASSFISH-17899] hk2/class-model.jar contains classes which are also present in hk2/auto-depends.jar with different versions causing osgi resolver error Created: 05/Dec/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: other
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Blocker
Reporter: Sanjeeb Sahoo Assignee: Sanjeeb Sahoo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by GLASSFISH-17898 Start domain failed on AIX - caused s... Closed
Tags: 3_1_2-review, 3_2-exclude

 Description   

See stack trace below which says that class-model classes are found in two different bundles with different package versions. That results in a constraint violation.
[exec] Launching GlassFish on Felix platform
[exec] Completed shutdown of GlassFish runtime
[exec] Exception in thread "main" java.lang.reflect.InvocationTargetException
[exec] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[exec] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[exec] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[exec] at java.lang.reflect.Method.invoke(Method.java:597)
[exec] at com.sun.enterprise.glassfish.bootstrap.GlassFishMain.main(GlassFishMain.java:97)
[exec] at com.sun.enterprise.glassfish.bootstrap.ASMain.main(ASMain.java:55)
[exec] Caused by: com.sun.enterprise.module.ResolveError: Failed to start Bundle Id [248] State [INSTALLED] [org.glassfish.main.core.kernel(Kernel Classes):3.1.2.SNAPSHOT]
[exec] at org.jvnet.hk2.osgiadapter.OSGiModuleImpl.start(OSGiModuleImpl.java:177)
[exec] at org.jvnet.hk2.osgiadapter.OSGiModuleImpl$2$1$1.loadClass(OSGiModuleImpl.java:344)
[exec] at com.sun.hk2.component.LazyInhabitant.loadClass(LazyInhabitant.java:124)
[exec] at com.sun.hk2.component.LazyInhabitant.type(LazyInhabitant.java:99)
[exec] at org.jvnet.hk2.component.Habitat$SelfListener.inhabitantIndexChanged(Habitat.java:1134)
[exec] at org.jvnet.hk2.component.Habitat$3.inhabitantChanged(Habitat.java:599)
[exec] at org.jvnet.hk2.component.Habitat$4.run(Habitat.java:640)
[exec] at org.jvnet.hk2.component.SameThreadExecutor.execute(SameThreadExecutor.java:80)
[exec] at org.jvnet.hk2.component.Habitat.doNotify(Habitat.java:630)
[exec] at org.jvnet.hk2.component.Habitat.notify(Habitat.java:617)
[exec] at org.jvnet.hk2.component.Habitat.notify(Habitat.java:603)
[exec] at org.jvnet.hk2.component.Habitat.addIndex(Habitat.java:429)
[exec] at org.jvnet.hk2.component.Habitat.addIndex(Habitat.java:422)
[exec] at com.sun.hk2.component.InhabitantsParser.addIndex(InhabitantsParser.java:243)
[exec] at com.sun.hk2.component.InhabitantsParser.add(InhabitantsParser.java:222)
[exec] at com.sun.hk2.component.InhabitantsParser.parse(InhabitantsParser.java:174)
[exec] at org.jvnet.hk2.osgiadapter.OSGiModuleImpl.parseInhabitants(OSGiModuleImpl.java:376)
[exec] at org.jvnet.hk2.osgiadapter.OSGiModulesRegistryImpl.parseInhabitants(OSGiModulesRegistryImpl.java:321)
[exec] at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.createHabitat(AbstractModulesRegistryImpl.java:156)
[exec] at com.sun.enterprise.module.bootstrap.Main.createHabitat(Main.java:425)
[exec] at org.jvnet.hk2.osgiadapter.HK2Main.createHabitat(HK2Main.java:96)
[exec] at com.sun.enterprise.glassfish.bootstrap.osgi.EmbeddedOSGiGlassFishRuntime.newGlassFish(EmbeddedOSGiGlassFishRuntime.java:89)
[exec] at com.sun.enterprise.glassfish.bootstrap.GlassFishMain$Launcher.launch(GlassFishMain.java:113)
[exec] ... 6 more
[exec] Caused by: org.osgi.framework.BundleException: Uses constraint violation. Unable to resolve bundle revision org.glassfish.main.core.kernel [248.0] because it is exposed to package 'org.glassfish.hk2.classmodel.reflect.util' from bundle revisions org.glassfish.hk2.auto-depends [221.0] and org.glassfish.hk2.class-model [5.0] via two dependency chains.
[exec]
[exec] Chain 1:
[exec] org.glassfish.main.core.kernel [248.0]
[exec] import: (&(osgi.wiring.package=org.glassfish.hk2.classmodel.reflect.util)(version>=1.0.0))
[exec] |
[exec] export: osgi.wiring.package=org.glassfish.hk2.classmodel.reflect.util
[exec] org.glassfish.hk2.auto-depends [221.0]
[exec]
[exec] Chain 2:
[exec] org.glassfish.main.core.kernel [248.0]
[exec] import: (&(osgi.wiring.package=org.jvnet.hk2.config)(version>=1.0.0))
[exec] |
[exec] export: osgi.wiring.package=org.jvnet.hk2.config; uses:=org.glassfish.hk2.classmodel.reflect
[exec] org.glassfish.hk2.config [112.0]
[exec] import: (&(osgi.wiring.package=org.glassfish.hk2.classmodel.reflect)(version>=1.1.0))
[exec] |
[exec] export: osgi.wiring.package=org.glassfish.hk2.classmodel.reflect; uses:=org.glassfish.hk2.classmodel.reflect.util
[exec] export: osgi.wiring.package=org.glassfish.hk2.classmodel.reflect.util
[exec] org.glassfish.hk2.class-model [5.0]
[exec] at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:3832)
[exec] at org.apache.felix.framework.Felix.startBundle(Felix.java:1868)
[exec] at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:944)
[exec] at org.jvnet.hk2.osgiadapter.OSGiModuleImpl.start(OSGiModuleImpl.java:169)
[exec] ... 28 more
[exec]

There are two solutions:
I don't know who has changed hk2/auto-depends, but it bundles class-model and tiger_type classes. Although glassfish-hk2 packager is coded to exclude tiger_types.jar, it does not exclude class-model.jar. So, class-model.jar is also present in every distro that contains hk2. The issue is not this duplication of classes in two jars, the real problem is class-model.jar does not export the packages with a version unlike auto-depends.jar. It is perhaps an oversight by whoever added class-model module. So, we are some times facing issues in OSGi package resolution as it is thinking them as distinct packages. We have two ways to solve it:

1) stop distributing class-model.jar in distro and optionally fix class-model.jar to export with proper version.
or
2) stop repackaging classes in auto-depends.jar and fix class-model.jar to export with proper version.

#1 is preferable as it avoids one extra module.



 Comments   
Comment by Sanjeeb Sahoo [ 06/Dec/11 ]

svn details:
3.1.2 branch: r51283

This does not have to be forward ported to trunk, as trunk uses a different version of HK2 which does not have the duplicate package issue.





[GLASSFISH-17894] Both JSF 2.1.0 and 2.1.4 embedded and jar mixup Created: 04/Dec/11  Updated: 08/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: jsf
Affects Version/s: 3.1.2_b12
Fix Version/s: 3.1.2_b13, 3.1.2_b14

Type: Bug Priority: Major
Reporter: fabmars Assignee: Ed Burns
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Win7 x86


Attachments: Text File changebundle.txt    
Tags: 3_1_2-review, build, fish, glass, jsf

 Description   

After installation of glassfish-3.1.2-b12-windows.exe, one can see in /glassfish3/glassfish/modules:

  • javax.faces.jar containing both api and impl JSF 2.1.4 (20111107-SNAPSHOT)
  • jsf-impl.jar containing JSF 2.1.0 (2.1.0-b11-FCS)
  • NO jsf-api.jar (so the eclipse glassfish plugin also gets upset)

It was already like that on 3.1.2-b10, the first promoted I tried.
On 3.1.1 there were only jsf-api.jar and jsf-impl.jar, but I heard there were discussions over a new javax jar scheme in 3.1.2.

Workaround: rework the jars manually from the distrib.



 Comments   
Comment by rogerk [ 05/Dec/11 ]

We did switch over to one JSF jar in the modules directory - namely javax.faces.jar.
However, I just downloaded a promoted zip distribution - glassfish-3.1.2-b12.zip
unzipped it, and noticed that under the modules directory there was:
jsf-api.jar
jsf-impl.jar
javax.faces.jar

Comment by rogerk [ 05/Dec/11 ]

From: snjezana.sevozenzerovic@oracle.com
To: roger.kitain@oracle.com
Sent: Monday, December 5, 2011 1:41:25 PM GMT -08:00 US/Canada Pacific
Subject: Fwd: [JIRA] Commented: (GLASSFISH-17894) Both JSF 2.1.0 and 2.1.4 embedded and jar mixup

[I would have commented directly on the issue but for some reason java.net barfs when I try to log in...]

Roger, I think you are missing jsf-api and jsf-impl exclusions in packager/pom.xml file in 3.1.2 branch so old jsf jars get pulled in as transitive dependencies of some external project. I think I already mentioned this to Ed week or so ago but he apparently never updated the file.

Thanks,

Snjezana

Comment by rogerk [ 05/Dec/11 ]

On 12/5/11 4:43 PM, Snjezana Sevo-Zenzerovic wrote:
> Just checked - jsf-api is on the exclude list and I don't see it in freshly built distribution anymore. So, please add jsf-impl to the list, too, make sure you don't see it in the distribution anymore and at point you should be able to close this issue.
>
> Thanks,
>
> Snjezana

Comment by rogerk [ 05/Dec/11 ]

Looks like pilot error -

jsf-ri is listed in list for <packager.artifact.excludes>.
It should probably be listed as jsf-impl

Ed is doing a 2.1.6 integration into 3.1.2 so we'll make sure that is fixed.

Comment by rogerk [ 05/Dec/11 ]

Ed - we need to make sure GlassFish packager/pom.xml file has jsf-impl on <packager.artifact.excludes> list (instead of jsf-ri) for 2.1.6 integration.

Comment by Ed Burns [ 06/Dec/11 ]

Consider this text from the Maven and OSGi packaging and naming guide <http://www.java.net/external?url=http://wikis.sun.com/display/GlassFish/Maven+Versioning+Rules>.

B> - an implementation jar file
B>
B> If the Java specification defines a standalone version of the
B> technology, the implementation jar file will be such a
B> standalone implementation of the specification, and will meet
B> all the compatibility requirements of the specification. The
B> implementation jar file typically includes all the classes from
B> the API jar file, plus whatever implementation classes are needed
B> to produce a complete runtime.

The correct distribution should have only javax.faces.jar, not jsf-api.jar and jsf-impl.jar. I am certain that the mojarra integration done just before the blog entry where I described all this <http://weblogs.java.net/blog/edburns/archive/2011/09/02/jcpjavaee-artifacts-maven-central> was correct and had only the one jar.

Somehow the multiple jars have crept back in. I will fix it.

Ed

Comment by Ed Burns [ 06/Dec/11 ]

Yes, I made this mistake:

svn cat -r 49388 packager/pom.xml | grep jsf-ri
<packager.artifact.excludes>stax-api,stax,junit,jtype,tiger-types,servlet-api,jstl-api,el-api,jsp-api,org.osgi.core,org.osgi.compendium,concurrent,amx-core,amx-core-impl,amx-config,amx-config-impl,amx-j2ee,amx-j2ee-impl,amx-ext-impl,gmbal-api-only,jsf-api,jsf-ri</packager.artifact.excludes>

When I committed revision 49388 on that file, the string "jsf-ri" should have been "jsf-impl".

Fixing this now.

Ed

Comment by Ed Burns [ 06/Dec/11 ]

Ready for review.

Comment by Ed Burns [ 06/Dec/11 ]

Extraneous Mojarra jar in GlassFish zip http://java.net/jira/browse/GLASSFISH-17894

SECTION: Modified files

M packager/pom.xml

Correct error committed by edburns on revision 49388. In the
packager.artifact.excludes list, the string "jsf-ri" should be
"jsf-impl".

r=snjezana
Sending packager/pom.xml
Transmitting file data .
Committed revision 51320.

Comment by fabmars [ 07/Dec/11 ]

jsf-impl.jar is still present in b13.

Comment by fabmars [ 08/Dec/11 ]

and the same for EL





[GLASSFISH-17867] Error thrown in console upon clicking Java Message Service Node Created: 01/Dec/11  Updated: 01/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: None
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: shaline Assignee: Jason Lee
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OS: Windows 2008 Server
FF 8.0.1
GF 3.1.2 b12


Attachments: JPEG File JavaMessageService.jpg    

 Description   

When we click the server-config/Java Message Service node in the left tree, the below error is displayed in the console.
An error has occurred
REST Request 'https://localhost:4848/management/domain/clusters/cluster//list-instances' failed with response code '404'.

-Have attached the screenshot.

This error is seen both in Console accessed in localhost and remote host with secure admin enabled. This issue can be seen even with a instance-config/Java Message Service node.

Server.log has the below message:

[#|2011-11-30T19:36:26.348-0800|SEVERE|glassfish3.1.2|org.glassfish.admingui|_ThreadID=26;_ThreadName=Thread-2;|RestResponse.getResponse() gives FAILURE. endpoint = 'https://localhost:4848/management/domain/clusters/cluster//list-instances'; attrs = '{}'|#]



 Comments   
Comment by Jason Lee [ 01/Dec/11 ]

We shouldn't look up cluster information for server-config. Fix committed to branch (r51229) and trunk (51230).





[GLASSFISH-17862] cannot create cluster from console: class java.lang.RuntimeException thrown Created: 01/Dec/11  Updated: 01/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: None
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: shaline Assignee: Jason Lee
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

windows 2008 server
ff 8.0.1
GF 3.1.2 b12


Attachments: JPEG File new-cluster.jpg    

 Description   

When trying to create a cluster from the Admin Console, java.lang.RuntimeException is seen in the Console screen. Tried in both localhost without secure-admin enabled , and in remote host with secure admin enabled, and saw this issue.
Have attached the screenshot.

Server.log has no exceptions or error messages.



 Comments   
Comment by Jason Lee [ 01/Dec/11 ]

I just tried on a clean build (no relevant uncommitted changes, no uncommitted files) and it worked fine. What build are you using?

Comment by shaline [ 01/Dec/11 ]

I saw this issue on the GF 3.1.2 Promoted b12.

Comment by Jason Lee [ 01/Dec/11 ]

Can you reproduce it on a nightly or dev build?

Comment by shaline [ 01/Dec/11 ]

I tried this on the latest nightly dated b13_11-30-2011 on windows 2008 server . I am still seeing this issue. Browser used is firefox 8.0.1. Click on the New button to create a new cluster, and console displays : java.lang.RuntimeException .

Comment by Jason Lee [ 01/Dec/11 ]

And absolutely nothing in the logs?

Comment by shaline [ 01/Dec/11 ]

On FF 3.6.24, upon clicking New button, the below HTTP Status 500 Error is displayed in the console: and the server.log has the stack mentioned below:

HTTP Status 500 -

type Exception report

message

descriptionThe server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: java.lang.reflect.InvocationTargetException while attempting to process a 'afterCreate' event for 'event172'.

root cause

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException while attempting to process a 'afterCreate' event for 'event172'.

root cause

java.lang.reflect.InvocationTargetException

root cause

com.sun.jsftemplating.layout.LayoutDefinitionException: No LayoutDefinitionManager available for '/jms/configureJmsCluster.inc'. This may mean the file cannot be found, or is unrecognizable.

note The full stack traces of the exception and its root causes are available in the GlassFish Server Open Source Edition 3.1.2-SNAPSHOT logs.

***************************************************************

server.log has the below Excpeiton stack:

[#|2011-12-01T10:51:53.538-0800|WARNING|glassfish3.1.2|javax.enterprise.system.container.web.com.sun.enterprise.web|_ThreadID=29;_ThreadName=Thread-2;|StandardWrapperValve[FacesServlet]: PWC1406: Servlet.service() for servlet FacesServlet threw exception
com.sun.jsftemplating.layout.LayoutDefinitionException: No LayoutDefinitionManager available for '/jms/configureJmsCluster.inc'. This may mean the file cannot
be found, or is unrecognizable.
at com.sun.jsftemplating.layout.LayoutDefinitionManager.getLayoutDefinitionManager(LayoutDefinitionManager.java:354)
at com.sun.jsftemplating.layout.LayoutDefinitionManager.getLayoutDefinition(LayoutDefinitionManager.java:152)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ionPoint(PluginHandlers.java:444)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ionPoints(PluginHandlers.java:389)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ions(PluginHandlers.java:192)
at sun.reflect.GeneratedMethodAccessor190.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jsftemplating.layout.descriptors.handler.Handler.invoke(Handl
er.java:442)
at com.sun.jsftemplating.layout.descriptors.LayoutElementBase.dispatchHa
ndlers(LayoutElementBase.java:420)
at com.sun.jsftemplating.layout.descriptors.LayoutElementBase.dispatchHa
ndlers(LayoutElementBase.java:394)
at com.sun.jsftemplating.layout.descriptors.LayoutComponent.afterCreate(
LayoutComponent.java:363)
at com.sun.jsftemplating.layout.descriptors.LayoutComponent.getChild(Lay
outComponent.java:294)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:556)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:590)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:590)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:551)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:507)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:507)
at com.sun.jsftemplating.layout.LayoutViewHandler.createView(LayoutViewH
andler.java:255)
at com.sun.faces.lifecycle.RestoreViewPhase.execute(RestoreViewPhase.jav
a:247)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.jav
a:116)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)

at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593)
at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java
:1542)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:343)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:217)
at com.sun.webui.jsf.util.UploadFilter.doFilter(UploadFilter.java:233)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:256)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:217)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:279)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:175)
at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.j
ava:655)
at org.apache.catalina.core.StandardPipeline.doChainInvoke(StandardPipel
ine.java:600)
at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:96)
at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESess
ionLockingStandardPipeline.java:91)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:162)
at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.j
ava:331)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:231)
at com.sun.enterprise.v3.services.impl.ContainerMapper.service(Container
Mapper.java:232)
at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:8
33)
at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:730)
at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1031)
at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFil
ter.java:228)
at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultPro
tocolChain.java:137)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.jav
a:104)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.jav
a:90)
at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java
:79)
at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextT
ask.java:54)
at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.
java:59)
at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadP
ool.java:532)
at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool
.java:513)
at java.lang.Thread.run(Unknown Source)

#]

[#|2011-12-01T10:52:07.124-0800|WARNING|glassfish3.1.2|javax.enterprise.system.c
ontainer.web.com.sun.enterprise.web|_ThreadID=30;_ThreadName=Thread-2;|StandardW
rapperValve[FacesServlet]: PWC1406: Servlet.service() for servlet FacesServlet t
hrew exception
com.sun.jsftemplating.layout.LayoutDefinitionException: No LayoutDefinitionManag
er available for '/jms/configureJmsCluster.inc'. This may mean the file cannot
be found, or is unrecognizable.
at com.sun.jsftemplating.layout.LayoutDefinitionManager.getLayoutDefinit
ionManager(LayoutDefinitionManager.java:354)
at com.sun.jsftemplating.layout.LayoutDefinitionManager.getLayoutDefinit
ion(LayoutDefinitionManager.java:152)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ionPoint(PluginHandlers.java:444)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ionPoints(PluginHandlers.java:389)
at org.glassfish.admingui.common.handlers.PluginHandlers.includeIntegrat
ions(PluginHandlers.java:192)
at sun.reflect.GeneratedMethodAccessor190.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jsftemplating.layout.descriptors.handler.Handler.invoke(Handl
er.java:442)
at com.sun.jsftemplating.layout.descriptors.LayoutElementBase.dispatchHa
ndlers(LayoutElementBase.java:420)
at com.sun.jsftemplating.layout.descriptors.LayoutElementBase.dispatchHa
ndlers(LayoutElementBase.java:394)
at com.sun.jsftemplating.layout.descriptors.LayoutComponent.afterCreate(
LayoutComponent.java:363)
at com.sun.jsftemplating.layout.descriptors.LayoutComponent.getChild(Lay
outComponent.java:294)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:556)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:590)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:590)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:551)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:507)
at com.sun.jsftemplating.layout.LayoutViewHandler.buildUIComponentTree(L
ayoutViewHandler.java:507)
at com.sun.jsftemplating.layout.LayoutViewHandler.createView(LayoutViewH
andler.java:255)
at com.sun.faces.lifecycle.RestoreViewPhase.execute(RestoreViewPhase.jav
a:247)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.jav
a:116)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)

at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593)
at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java
:1542)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:343)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:217)
at com.sun.webui.jsf.util.UploadFilter.doFilter(UploadFilter.java:233)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:256)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:217)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:279)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:175)
at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.j
ava:655)
at org.apache.catalina.core.StandardPipeline.doChainInvoke(StandardPipel
ine.java:600)
at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:96)
at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESess
ionLockingStandardPipeline.java:91)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:162)
at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.j
ava:331)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:231)
at com.sun.enterprise.v3.services.impl.ContainerMapper.service(Container
Mapper.java:232)
at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:8
33)
at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:730)
at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1031)
at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFil
ter.java:228)
at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultPro
tocolChain.java:137)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.jav
a:104)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.jav
a:90)
at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java
:79)
at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextT
ask.java:54)
at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.
java:59)
at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadP
ool.java:532)
at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool
.java:513)
at java.lang.Thread.run(Unknown Source)

#]
Comment by Jason Lee [ 01/Dec/11 ]

This bug was reported and fixed yesterday in the branch (r51196) and trunk (r51200).





[GLASSFISH-17858] Failed start-instance on SSH reports "null" for command executed. Created: 30/Nov/11  Updated: 01/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin
Affects Version/s: 3.1.2_b10
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: Joe Di Pol Assignee: Joe Di Pol
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-review

 Description   

I ran 3.1.2 B10 start-instance on a setup that failed, and it reported an error like this:

Could not start instance i1 on node node1 (10.132.181.201).: Command 'null' failed on node node1 (10.132.181.201):

Note that instead of displaying the command that was run, it is displaying "null". This correctly displayed the command in 3.1.1, so it is a regression.



 Comments   
Comment by Joe Di Pol [ 30/Nov/11 ]

Looks like this was caused when the NodeRunner code was refactored to support DCOM. Specifically in NodeRunner, "lastCommandRun" is never set when a remote command is executed using SSH. We need to propogate lastCommandRun from NodeRunnerSSH to NodeRunner.

Comment by Joe Di Pol [ 01/Dec/11 ]

Fixed in 3.1.2 branch (r51215) and trunk (r51219)

Project:    glassfish
Repository: svn
Revision:   51215
Author:     jfdipol
Date:       2011-11-30 23:16:22 UTC
Link:       

Log Message:
------------
Fix 17858 Failed start-instance on SSH reports "null" for command executed

Also fix missing parameter on another message.




Revisions:
----------
51215


Modified Paths:
---------------
branches/3.1.2/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/NodeUtils.java
branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunnerSsh.java
branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunner.java


Diffs:
------
Index: branches/3.1.2/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/NodeUtils.java
===================================================================
--- branches/3.1.2/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/NodeUtils.java	(revision 51214)
+++ branches/3.1.2/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/NodeUtils.java	(revision 51215)
@@ -499,7 +499,7 @@
                             m1, m2));
             }
             else {
-                String msg = Strings.get("ssh.bad.connect", nodehost);
+                String msg = Strings.get("ssh.bad.connect", nodehost, "SSH");
                 logger.warning(StringUtils.cat(": ", msg, m1, m2,
                         sshL.toString()));
                 throw new CommandValidationException(StringUtils.cat(NL,
Index: branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunner.java
===================================================================
--- branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunner.java	(revision 51214)
+++ branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunner.java	(revision 51215)
@@ -220,7 +220,9 @@
 
         if ("SSH".equals(type)) {
             NodeRunnerSsh nrs = new NodeRunnerSsh(habitat, logger);
-            return nrs.runAdminCommandOnRemoteNode(node, output, args, stdinLines);
+            int result = nrs.runAdminCommandOnRemoteNode(node, output, args, stdinLines);
+            lastCommandRun = nrs.getLastCommandRun();
+            return result;
         }
 
         if ("DCOM".equals(type)) {
Index: branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunnerSsh.java
===================================================================
--- branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunnerSsh.java	(revision 51214)
+++ branches/3.1.2/cluster/ssh/src/main/java/org/glassfish/cluster/ssh/connect/NodeRunnerSsh.java	(revision 51215)
@@ -84,6 +84,9 @@
         return node.getType().equals("SSH");
     }
 
+    String getLastCommandRun() {
+        return lastCommandRun;
+    }
 
     public int runAdminCommandOnRemoteNode(Node node, StringBuilder output,
                                        List<String> args,





[GLASSFISH-17857] request.getHeader does not return the trailer on chunked POST requests with trailers Created: 30/Nov/11  Updated: 07/Dec/11  Resolved: 07/Dec/11

Status: Resolved
Project: glassfish
Component/s: web_container
Affects Version/s: None
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: Shing Wai Chan Assignee: Shing Wai Chan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When we post a chunked requests with trailers, the request#getHeader does not return the trailer header.

On need to port the fix of https://issues.apache.org/bugzilla/show_bug.cgi?id=49860 ,
http://svn.apache.org/viewvc?view=revision&revision=1003461



 Comments   
Comment by Shing Wai Chan [ 30/Nov/11 ]

Change in Grizzly 1.9.x:
git commit config/src/main/java/com/sun/grizzly/config/dom/Http.java http/src/main/java/com/sun/grizzly/http/Constants.java http/src/main/java/com/sun/grizzly/http/ProcessorTask.java http/src/main/java/com/sun/grizzly/http/SelectorThread.java utils/src/main/java/com/sun/grizzly/tcp/http11/filters/ChunkedInputFilter.java
[1.9.x e96c71a] fix issue http://java.net/jira/browse/GLASSFISH-17857 ("request.getHeader does not return the trailer on chunked POST requests with trailers")
5 files changed, 218 insertions, 7 deletions

git push origin 1.9.x
Counting objects: 62, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (24/24), done.
Writing objects: 100% (35/35), 4.06 KiB, done.
Total 35 (delta 14), reused 0 (delta 0)
To ssh://swchan2@git.java.net/grizzly~git
f7a798f..68bf225 1.9.x -> 1.9.x

Add devtests:
Adding trailerHeader
Adding trailerHeader/WebTest.java
Adding trailerHeader/build.properties
Adding trailerHeader/build.xml
Adding trailerHeader/descriptor
Adding trailerHeader/descriptor/web.xml
Adding trailerHeader/servlet
Adding trailerHeader/servlet/EchoHeaderServlet.java
Transmitting file data .....
Committed revision 51207.

Comment by oleksiys [ 07/Dec/11 ]

Grizzly issue
http://java.net/jira/browse/GRIZZLY-1146





[GLASSFISH-17854] Integrate Grizzly 1.9.42 Created: 30/Nov/11  Updated: 05/Dec/11  Resolved: 05/Dec/11

Status: Resolved
Project: glassfish
Component/s: grizzly-kernel
Affects Version/s: 3.1.1_b12
Fix Version/s: 3.1.2_b13

Type: Task Priority: Major
Reporter: oleksiys Assignee: oleksiys
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Dependency
blocks GLASSFISH-17845 Unnecessary and misleading log entry Closed

 Description   

Integrate Grizzly 1.9.42



 Comments   
Comment by oleksiys [ 05/Dec/11 ]

integrated

Project: glassfish
Repository: svn
Revision: 51279
Author: oleksiys
Date: 2011-12-05 22:36:12 UTC
Link:

Log Message:
------------
+ integrate Grizzly 1.9.42
fix issue #17854
http://java.net/jira/browse/GLASSFISH-17854





[GLASSFISH-17850] Null Pointer exception when export LB Config in Admin Console Created: 30/Nov/11  Updated: 12/Dec/11  Resolved: 06/Dec/11

Status: Closed
Project: glassfish
Component/s: admin_gui
Affects Version/s: 3.1.2_b12
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: arunkumar_s Assignee: srinik76
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

RHL


Issue Links:
Related
is related to GLASSFISH-17923 get-client-stubs: failed with secure... Resolved
is related to GLASSFISH-17922 collect-log-files: cannot download l... Closed

 Description   

Steps:

1) Install/Unzip OGS bits and start-domain
2) Change Admin login password from empty password to some password
3) Login Admin console and create a LB with default values.
4) Open the created LB in console and click export now button in Export Tab

HTTP status 500 Error with

java.lang.RuntimeException: java.lang.NullPointerException error message appears in browser.

Server Logs:
-----------

[#|2011-11-30T14:28:47.073+0530|INFO|glassfish3.1.2|javax.enterprise.system.tools.admin.com.sun.enterprise.container.common|_ThreadID=26;_ThreadName=Thread-2;|User [] from host localhost.localdomain does not have administration access|#]

[#|2011-11-30T14:28:47.076+0530|WARNING|glassfish3.1.2|javax.enterprise.system.container.web.com.sun.enterprise.web|_ThreadID=20;_ThreadName=Thread-2;|StandardWrapperValve[DownloadServlet]: PWC1406: Servlet.service() for servlet DownloadServlet threw exception
java.lang.RuntimeException: java.lang.NullPointerException
at org.glassfish.admingui.common.servlet.LBConfigContentSource.getInputStream(LBConfigContentSource.java:114)
at org.glassfish.admingui.common.servlet.DownloadServlet.writeContent(DownloadServlet.java:277)
at org.glassfish.admingui.common.servlet.DownloadServlet.doPost(DownloadServlet.java:174)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1542)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:281)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:655)
at org.apache.catalina.core.StandardPipeline.doChainInvoke(StandardPipeline.java:600)
at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:96)
at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:91)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:162)
at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:331)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:231)
at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:232)
at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:833)
at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:730)
at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1031)
at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:228)
at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:137)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:104)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:90)
at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:79)
at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:54)
at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:59)
at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:532)
at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:513)
at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.NullPointerException
at org.glassfish.admingui.common.util.RestUtil.restRequest(RestUtil.java:199)
at org.glassfish.admingui.common.util.RestUtil.restRequest(RestUtil.java:149)
at org.glassfish.admingui.common.servlet.LBConfigContentSource.getInputStream(LBConfigContentSource.java:110)
... 29 more

#]


 Comments   
Comment by srinik76 [ 06/Dec/11 ]

When admin password is set the rest request is failing in the servlet. So trying to get the rest token from servlet http session and authenticate the rest request.

checked in the fix into 3.1.2 branch,

Sending common/src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java
Transmitting file data .
Committed revision 51286.

the svn diff is

Index: src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java
===================================================================
— src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java (revision 51248)
+++ src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java (working copy)
@@ -59,8 +59,18 @@
import java.util.HashMap;
import java.util.Map;

-import javax.servlet.ServletRequest;
import org.glassfish.admingui.common.util.RestUtil;
+import com.sun.jersey.api.client.Client;
+import com.sun.jersey.api.client.ClientResponse;
+import com.sun.jersey.api.client.WebResource;
+import com.sun.jersey.api.client.filter.HTTPBasicAuthFilter;
+import com.sun.jersey.core.util.MultivaluedMapImpl;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+import javax.ws.rs.core.Cookie;
+import javax.ws.rs.core.MultivaluedMap;
+import org.glassfish.admingui.common.security.AdminConsoleAuthModule;
+import org.glassfish.admingui.common.util.RestResponse;

/**
*
@@ -91,7 +101,8 @@
ctx.setAttribute(DownloadServlet.EXTENSION, "LB-CONFIG");

// Get appName

  • ServletRequest request = ctx.getServletRequest();
    + HttpServletRequest request = (HttpServletRequest) ctx.getServletRequest();
    + HttpSession session = request.getSession();
    String lbName = request.getParameter("lbName");
    String restUrl = request.getParameter("restUrl");

@@ -107,7 +118,16 @@
String slbFile = tempDir + System.getProperty("file.separator") + lbFileName;
File lbFile = new File(slbFile);
attrsMap.put("id", slbFile);

  • RestUtil.restRequest( endpoint , attrsMap, "post", null, false);
    + Client client2 = RestUtil.JERSEY_CLIENT;
    + WebResource webResource = client2.resource(endpoint);
    + String token = (String) session.getAttribute(AdminConsoleAuthModule.REST_TOKEN);
    + MultivaluedMap formData = new MultivaluedMapImpl();
    + formData.putSingle("id", slbFile);
    + ClientResponse cr = webResource
    + .cookie(new Cookie("gfresttoken", token))
    + .accept(RestUtil.RESPONSE_TYPE).post(ClientResponse.class, formData);
    + RestResponse rr = RestResponse.getRestResponse(cr);
    + RestUtil.parseResponse(rr, null, endpoint, attrsMap, true, true);
    tmpFile = new FileInputStream(lbFile);
    lbFile.delete();
    } catch (Exception ex) {
Comment by srinik76 [ 06/Dec/11 ]

Checked in the fix into 3.1.2_b13 branch.

Comment by srinik76 [ 06/Dec/11 ]

Checked into the trunk.

Sending common/src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java
Transmitting file data .
Committed revision 51287.

Comment by srinik76 [ 06/Dec/11 ]

Need to add the fix version to 4.0

Comment by srinik76 [ 06/Dec/11 ]

Added the fix version to 4.0

Comment by srinik76 [ 12/Dec/11 ]

Optimizing the fix. Checkin to 3.1.2

Sending common/src/main/java/org/glassfish/admingui/common/util/RestUtil.java
Transmitting file data .
Committed revision 51479.

Comment by srinik76 [ 12/Dec/11 ]

Sending org/glassfish/admingui/common/servlet/LBConfigContentSource.java
Transmitting file data .
Committed revision 51480.

Comment by srinik76 [ 12/Dec/11 ]

Sending common/src/main/java/org/glassfish/admingui/common/servlet/LBConfigContentSource.java
Sending common/src/main/java/org/glassfish/admingui/common/util/RestUtil.java
Transmitting file data ..
Committed revision 51481.

Checked into trunk





[GLASSFISH-17849] Layout Definiton exception when trying to create cluster in admin console Created: 30/Nov/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: 3.1.2_b12
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: arunkumar_s Assignee: Jason Lee
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

RHL



 Description   

Steps

1) Login GF admin console.
2) Click Clusters in left tree pane and Click New

Issue :
-------

HTTP Status 500 -

type Exception report

message

descriptionThe server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: java.lang.reflect.InvocationTargetException while attempting to process a 'afterCreate' event for 'event234'.

root cause

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException while attempting to process a 'afterCreate' event for 'event234'.

root cause

java.lang.reflect.InvocationTargetException

root cause

com.sun.jsftemplating.layout.LayoutDefinitionException: No LayoutDefinitionManager available for '/jms/configureJmsCluster.inc'. This may mean the file cannot be found, or is unrecognizable.



 Comments   
Comment by Jason Lee [ 30/Nov/11 ]

Missing file committed.





[GLASSFISH-17845] Unnecessary and misleading log entry Created: 30/Nov/11  Updated: 13/Jan/12  Resolved: 05/Dec/11

Status: Closed
Project: glassfish
Component/s: grizzly-kernel
Affects Version/s: 3.1.2_b12
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Minor
Reporter: lidiam Assignee: oleksiys
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows XP, ogs-3.1.2-b12-11_28_2011.zip


Attachments: Text File server.log    
Issue Links:
Dependency
depends on GLASSFISH-17854 Integrate Grizzly 1.9.42 Resolved
Tags: 312_verified

 Description   

When starting/stopping a standalone instance the following is printed several times to the DAS server.log:

[#|2011-11-29T16:37:09.911-0800|INFO|glassfish3.1.2|com.sun.grizzly.config.GrizzlyServiceListener|_ThreadID=22;_ThreadName=Thread-2;|parameters.invalidChunk|#]

This message seems unnecessary and could be confusing to the users. Server.log attached.



 Comments   
Comment by oleksiys [ 30/Nov/11 ]

will be fixed with the next Grizzly 1.9.42 integration

Comment by oleksiys [ 05/Dec/11 ]

resolved

Comment by lidiam [ 13/Jan/12 ]

Verified in Glassfish build ogs-3.1.2-b17.zip





[GLASSFISH-17844] SSL failure when accessing admin console from a different machine Created: 29/Nov/11  Updated: 01/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: 3.1.2_b09
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: ljnelson Assignee: Jason Lee
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: admin-gui, fishcat

 Description   

Hello; some of my developers are reporting that with Glassfish 3.1.2 build 9 any attempt to access the administration console remotely (from a different machine's web browser) fails.

Here are the steps to reproduce the problem:

Install Glassfish normally.

Start the server:

asadmin start-domain

Change the administration password:

asadmin change-admin-password
Enter admin user name [default: admin]> admin
Enter admin password> <return>
Enter new admin password> somepassword
Enter new admin password again> somepassword
Command change-admin-password executed successfully.

Enable "secure admin":

asadmin enable-secure-admin
Enter admin user name>  admin
Enter admin password for user "admin">
Command enable-secure-admin executed successfully.

Stop the server:

asadmin stop-domain
{noformoat}

Start the server:

asadmin start-domain

Now navigate to that machine's port 4848 from another box.  Put in {{admin}} for the username and {{somepassword}} for the password.

A blank screen results (the URL reflects the {{j_security_check}} destination).

The log file says, in part:
{{noformat}}
Caused by: java.io.EOFException: SSL peer shut down incorrectly
        at com.sun.net.ssl.internal.ssl.InputRecord.read(InputRecord.java:333)
        at com.sun.net.ssl.internal.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:798)
        ... 57 more
{

}



 Comments   
Comment by Tim Quinn [ 29/Nov/11 ]

I tried the same experiment with a fresh check-out and rebuilt (as of Nov. 29). I saw the same behavior at the browser but got a different stack trace.

[#|2011-11-29T15:31:32.538-0600|SEVERE|glassfish3.1.2|org.apache.catalina.connector.CoyoteAdapter|_ThreadID=26;_ThreadName=Thread-2;|PWC3989: An exception or error occurred in the container during the request processing
java.lang.IllegalStateException: PWC2776: invalidate: Session already invalidated
	at org.apache.catalina.session.StandardSession.invalidate(StandardSession.java:1467)
	at org.apache.catalina.session.StandardSessionFacade.invalidate(StandardSessionFacade.java:204)
	at org.glassfish.admingui.common.security.AdminConsoleAuthModule.validateRequest(AdminConsoleAuthModule.java:280)
	at com.sun.enterprise.security.jmac.config.GFServerConfigProvider$GFServerAuthContext.validateRequest(GFServerConfigProvider.java:1171)
	at com.sun.web.security.RealmAdapter.validate(RealmAdapter.java:1452)
	at com.sun.web.security.RealmAdapter.invokeAuthenticateDelegate(RealmAdapter.java:1330)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:551)
	at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:623)
	at org.apache.catalina.core.StandardPipeline.doChainInvoke(StandardPipeline.java:600)
	at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:96)
	at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:91)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:162)
	at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:331)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:231)
	at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:232)
	at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:833)
	at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:730)
	at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1031)
	at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:228)
	at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:137)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:104)
	at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:90)
	at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:79)
	at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:54)
	at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:59)
	at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:532)
	at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:513)
	at java.lang.Thread.run(Thread.java:680)
Comment by ljnelson [ 29/Nov/11 ]

Sorry about the formatting; it looks like I cannot go back into the description and edit my own typos. If someone with such privileges could do this for me I'm sure everyone would benefit.

Comment by Jason Lee [ 29/Nov/11 ]

I, however, can not reproduce this. Is this OS and/or browser specific? I'm running GlassFish on my Mac, and tested from my wife's Mac using Firefox (8.x, iirc).

Comment by ljnelson [ 29/Nov/11 ]

The OS our admin was running was SUSE Linux Enterprise 11. I am told this does not happen on Windows, either.

Comment by shaline [ 30/Nov/11 ]

I have the GF 3.1.2 promoted b11 installed on Windows 2008 server and have accessed console from a remote windows 2008 server
both on FF 8.x and IE 8 browsers, and have not seen this issue. After enabling secure admin and restarting domain, I am
able to successfully bring up the console from a remote browser.

Comment by lidiam [ 30/Nov/11 ]

I have Glassfish on a solaris sparc and access it from Windows XP, Firefox, IE and Chrome - have not seen this issue.

Comment by Tim Quinn [ 30/Nov/11 ]

My test scenario (which did not work) was this:

server - MacBook Pro running Mac OS X 10.5.8
client - iMac running Mac OS X 10.7.2 with Chrome (v 15.0.874.121)

Of course, I just retried it and it worked correctly.

To see if this might involve the first-time access to the console, I deleted the domain and recreated it and went through the steps again. Worked fine.

I even completely unzipped the glassfish.zip again just in case. Same successful result.

As I think about this, I think it's possible (likely) that I accidentally submitted the username and password twice from the log-in form, the second happening while the first was still in progress. I can believe that this might lead to something like the "session already invalidated" condition.

Laird, is there any chance that you might have accidentally submitted the form twice as well, the way I (think) I did? I can believe that the stack traces might be different depending on how far along the request processing was when the second submission arrived.

Comment by dmaranan [ 30/Nov/11 ]

I work with Laird. I am able to duplicate this on another SUSE Linux machine following the same instructions above. This is with build 3.1.2 b9. We'll try the most recent build and see if we get the same error. Here is the stack trace that I run into.

[#|2011-11-29T22:47:45.080-0500|SEVERE|glassfish3.1.2|org.apache.catalina.connector.CoyoteAdapter|_ThreadID=17;_ThreadName=Thread-2;|PWC3989: An exception or error occurred in the container during the request processing
com.sun.jersey.api.client.ClientHandlerException: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake
at com.sun.jersey.client.urlconnection.URLConnectionClientHandler.handle(URLConnectionClientHandler.java:149)
at com.sun.jersey.api.client.filter.CsrfProtectionFilter.handle(CsrfProtectionFilter.java:97)
at com.sun.jersey.api.client.Client.handle(Client.java:648)
at com.sun.jersey.api.client.filter.HTTPBasicAuthFilter.handle(HTTPBasicAuthFilter.java:81)
at com.sun.jersey.api.client.WebResource.handle(WebResource.java:670)
at com.sun.jersey.api.client.WebResource.access$200(WebResource.java:74)
at com.sun.jersey.api.client.WebResource$Builder.post(WebResource.java:563)
at org.glassfish.admingui.common.security.AdminConsoleAuthModule.validateRequest(AdminConsoleAuthModule.java:257)
at com.sun.enterprise.security.jmac.config.GFServerConfigProvider$GFServerAuthContext.validateRequest(GFServerConfigProvider.java:1171)
at com.sun.web.security.RealmAdapter.validate(RealmAdapter.java:1452)
at com.sun.web.security.RealmAdapter.invokeAuthenticateDelegate(RealmAdapter.java:1330)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:551)
at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:623)
at org.apache.catalina.core.StandardPipeline.doChainInvoke(StandardPipeline.java:600)
at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:96)
at com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:91)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:162)
at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:330)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:231)
at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:232)
at com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:833)
at com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:730)
at com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:1031)
at com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:228)
at com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:137)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:104)
at com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:90)
at com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:79)
at com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:54)
at com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:59)
at com.sun.grizzly.ContextTask.run(ContextTask.java:71)
at com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:532)
at com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:513)
at java.lang.Thread.run(Thread.java:619)
Caused by: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:808)
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1096)
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1123)
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1107)
at sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:415)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:166)
at sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:881)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getOutputStream(HttpsURLConnectionImpl.java:230)
at com.sun.jersey.client.urlconnection.URLConnectionClientHandler$1$1.getOutputStream(URLConnectionClientHandler.java:225)
at com.sun.jersey.api.client.CommittingOutputStream.commitWrite(CommittingOutputStream.java:117)
at com.sun.jersey.api.client.CommittingOutputStream.write(CommittingOutputStream.java:89)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:202)
at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:272)
at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:276)
at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:122)
at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:212)
at java.io.BufferedWriter.flush(BufferedWriter.java:236)
at com.sun.jersey.core.util.ReaderWriter.writeToAsString(ReaderWriter.java:191)
at com.sun.jersey.core.provider.AbstractMessageReaderWriterProvider.writeToAsString(AbstractMessageReaderWriterProvider.java:128)
at com.sun.jersey.core.impl.provider.entity.BaseFormProvider.writeTo(BaseFormProvider.java:109)
at com.sun.jersey.core.impl.provider.entity.FormMultivaluedMapProvider.writeTo(FormMultivaluedMapProvider.java:99)
at com.sun.jersey.core.impl.provider.entity.FormMultivaluedMapProvider.writeTo(FormMultivaluedMapProvider.java:59)
at com.sun.jersey.api.client.RequestWriter.writeRequestEntity(RequestWriter.java:300)
at com.sun.jersey.client.urlconnection.URLConnectionClientHandler._invoke(URLConnectionClientHandler.java:204)
at com.sun.jersey.client.urlconnection.URLConnectionClientHandler.handle(URLConnectionClientHandler.java:147)
... 33 more
Caused by: java.io.EOFException: SSL peer shut down incorrectly
at com.sun.net.ssl.internal.ssl.InputRecord.read(InputRecord.java:333)
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:789)
... 57 more

#]
Comment by Jason Lee [ 30/Nov/11 ]

Thanks. If you CAN reproduce it with a recent build, I guess I'll be installing a SuSE VM.

Comment by Jason Lee [ 01/Dec/11 ]

Do you have a status update on this? We are rapidly approaching our soft code freeze (SCF, in case you ever see that and I'd like to get this addressed before then if we can.

Comment by dmaranan [ 01/Dec/11 ]

This is all set. We updated to build 12 and we don't run into any issue. Thanks!

Comment by Jason Lee [ 01/Dec/11 ]

Beautiful. I'll go ahead and close this.





[GLASSFISH-17776] uptime is not returned correctly in actionReport for REST client consumption Created: 20/Nov/11  Updated: 14/Mar/12  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13, 4.0_b43

Type: Improvement Priority: Major
Reporter: Anissa Lam Assignee: Byron Nevins
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Dependency
blocks GLASSFISH-17585 display information returned by uptime Resolved

 Description   

Here is what localhost:4848/management/domain/uptime.json returns:

{"message":"Up 3 hrs 12 mins","command":"uptime AdminCommand","exit_code":"SUCCESS","extraProperties":{"methods":[

{"name":"GET"}

,{"messageParameters":{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}

It should return the milliseconds in the action report so that REST client can convert that appropriately to show in any locale.

Maybe provide the milliseconds as properties.

{"message":"Up 3 hrs 12 mins","command":"uptime AdminCommand","exit_code":"SUCCESS",
"properties":"11520000",
"extraProperties":{"methods":[

{"name":"GET"}

,{"messageParameters":{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}



 Comments   
Comment by Tom Mueller [ 21/Nov/11 ]

Assigning to owner of uptime subcommand.

Comment by Byron Nevins [ 05/Dec/11 ]

It is impossible to have this:

{"message":"Up 3 hrs 12 mins","command":"uptime AdminCommand","exit_code":"SUCCESS",
"properties":"11520000",
"extraProperties":{"methods":[

{"name":"GET"}

,{"messageParameters":{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}

But I can do this:

{"message":"Up 3 hrs 12 mins","command":"uptime AdminCommand","exit_code":"SUCCESS",
"properties":

{ "milliseconds": "11520000" }

,"extraProperties":{"methods":[

{"name":"GET"}

,{"messageParameters":{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}

===============

Acceptable?

Comment by Byron Nevins [ 06/Dec/11 ]

BEFORE:

{"message":"Up 4 hrs 31 mins","command":"uptime AdminCommand","exit_code":"SUCCESS","extraProperties":{"methods":[

{"name":"GET"}

,{"messageParameters":
{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}

==============================

AFTER:

{"message":"Up 1 mins 21 secs","command":"uptime AdminCommand","exit_code":"SUCCESS","properties":

{"milliseconds":"81849"}

,"extraProperties":{"methods
":[

{"name":"GET"}

,{"messageParameters":{"milliseconds":

{"acceptableValues":"","optional":"true","type":"boolean","defaultValue":"false"}

}}]}}

============================================

d:\gf\branches\3.1.2\core\kernel>svn commit d:\gf\trunk\main\nucleus\core\kernel d:\gf\branches\3.1.2\core\kernel
Sending D:\gf\branches\3.1.2\core\kernel\src\main\java\com\sun\enterprise\v3\admin\UptimeCommand.java
Sending D:\gf\trunk\main\nucleus\core\kernel\src\main\java\com\sun\enterprise\v3\admin\UptimeCommand.java
Transmitting file data ..
Committed revision 51282.





[GLASSFISH-17743] duplicate keys in property files Created: 15/Nov/11  Updated: 01/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: verifier
Affects Version/s: 3.1.2_b01
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: gmurr Assignee: Sanjeeb Sahoo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-review

 Description   

The new translation process prevent us from sending files for translation if duplicate keys are found in the property files. Please fix the following issues. Some keys may be present more than twice. Please double check for uniqueness.

"verifier-impl/src/main/resources/com/sun/enterprise/tools/verifier/LocalStrings.properties","Invalid java properties","Line 8186: Key ""com.sun.enterprise.tools.verifier.tests.web.runtime.ASServlet.failed"" has already appeared at line(s) 8182. Non-unique keys are likely to increase translation costs due to over-translating."



 Comments   
Comment by Sanjeeb Sahoo [ 01/Dec/11 ]

3.1.2:
Sending verifier/verifier-impl/src/main/resources/com/sun/enterprise/tools/verifier/LocalStrings.properties
Transmitting file data .
Committed revision 51225.

trunk:
Sending appserver/verifier/verifier-impl/src/main/resources/com/sun/enterprise/tools/verifier/LocalStrings.properties
Transmitting file data .
Committed revision 51226.





[GLASSFISH-17742] duplicate keys in property files Created: 15/Nov/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: cmp
Affects Version/s: 3.1.2_b01
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: gmurr Assignee: Mitesh Meswani
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-review

 Description   

The new translation process prevent us from sending files for translation if duplicate keys are found in the property files. Please fix the following issues. Some keys may be present more than twice. Please double check for uniqueness.

"persistence/cmp/ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/Bundle.properties","Invalid java properties","Line 125: Key ""STRING_IASCTS_NOI18N"" has already appeared at line(s) 116. Non-unique keys are likely to increase translation costs due to over-translating."

"persistence/cmp/support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/Bundle.properties","Invalid java properties","Line 587: Key ""JDO76604.diag.cause.1"" has already appeared at line(s) 578, 579. Non-unique keys are likely to increase translation costs due to over-translating."

"persistence/cmp/support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/Bundle.properties","Invalid java properties","Line 588: Key ""JDO76604.diag.check.1"" has already appeared at line(s) 580. Non-unique keys are likely to increase translation costs due to over-translating."

"persistence/cmp/support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/Bundle.properties","Invalid java properties","Line 589: Key ""JDO76604.diag.check.2"" has already appeared at line(s) 581. Non-unique keys are likely to increase translation costs due to over-translating."



 Comments   
Comment by Mitesh Meswani [ 30/Nov/11 ]

Fixed with 51182 in branch and 51183 in trunk





[GLASSFISH-17738] duplicate keys in property files Created: 15/Nov/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: admin
Affects Version/s: 3.1.2_b01
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: gmurr Assignee: Byron Nevins
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-review

 Description   

The new translation process prevent us from sending files for translation if duplicate keys are found in the property files. Please fix the following issues. Some keys may be present more than twice. Please double check for uniqueness.

"admin/server-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/services/LocalStrings.properties","Invalid java properties","Line 146: Key ""noSuitableServiceImplementation"" has already appeared at line(s) 102. Non-unique keys are likely to increase translation costs due to over-translating."



 Comments   
Comment by Tom Mueller [ 15/Nov/11 ]

This is related to the services implementation.

Comment by Byron Nevins [ 30/Nov/11 ]

Sending server-mgmt\src\main\java\com\sun\enterprise\admin\servermgmt\services\LocalStrings.properties
Transmitting file data .
Committed revision 51201.

D:\gf\trunk\main\nucleus\admin\server-mgmt>svn commit
Sending server-mgmt\src\main\java\com\sun\enterprise\admin\servermgmt\services\LocalStrings.properties
Transmitting file data .
Committed revision 51202.





[GLASSFISH-17628] #{foo[bar](baz)} fails with com.sun.el.parser.ParseException: Encountered "(" Created: 04/Nov/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: web_container
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: balusc Assignee: kchung
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Eclipse Indigo SR1, Glassfish 3.1.1, Win 7 x64



 Description   

As an example, this view:

<ui:param name="p1" value="#{bean}" />
<ui:param name="p2" value="method1" />
<ui:param name="p3" value="#{bean.toString()}" />

<h:form>
    <h:commandButton value="submit" action="#{p1[p2](p3)}" /> 
</h:form>

with this bean:

@ManagedBean
@RequestScoped
public class Bean {

    public void submit(String arg) {
        System.out.println("submit with " + arg);
    }

}

works fine on Tomcat 7.0.22, but Glassfish fails while loading the page:

Caused by: javax.el.ELException: Error Parsing: #{p1[p2](p3)}
	at com.sun.el.lang.ExpressionBuilder.createNodeInternal(ExpressionBuilder.java:174)
	at com.sun.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:191)
	at com.sun.el.lang.ExpressionBuilder.createMethodExpression(ExpressionBuilder.java:242)
	at com.sun.el.ExpressionFactoryImpl.createMethodExpression(ExpressionFactoryImpl.java:81)
	at org.jboss.weld.util.el.ForwardingExpressionFactory.createMethodExpression(ForwardingExpressionFactory.java:43)
	at org.jboss.weld.el.WeldExpressionFactory.createMethodExpression(WeldExpressionFactory.java:62)
	at com.sun.faces.facelets.tag.TagAttributeImpl.getMethodExpression(TagAttributeImpl.java:222)
	... 63 more
Caused by: com.sun.el.parser.ParseException: Encountered "(" at line 1, column 9.
Was expecting one of:
        (*snip*)

Chapter 1.19 of EL spec says:

ValueSuffix      ::= '.' Identifier MethodParameters?
                    | '[' Expression ']' MethodParameters?          <-- Look here
MethodParameters ::= '(' (Expression (',' Expression )* )? ')'

So, I think that Apache EL is right. Can you please fix it for Glassfish as well?



 Comments   
Comment by balusc [ 04/Nov/11 ]

I can't edit it anymore, but in the first snippet,

<ui:param name="p2" value="method1" />

should have been

<ui:param name="p2" value="submit" />
Comment by kchung [ 30/Nov/11 ]

Fixed.





[GLASSFISH-17624] add support for validate-dcom Created: 03/Nov/11  Updated: 02/Dec/11  Resolved: 02/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: 3.1.2
Fix Version/s: 3.1.2_b13, 3.1.2

Type: Improvement Priority: Major
Reporter: Anissa Lam Assignee: Anissa Lam
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Dependency
depends on GLASSFISH-16248 Implement Windows alternative to SSH Resolved
Sub-Tasks:
Key
Summary
Type
Status
Assignee
GLASSFISH-17810 OLH: validate-dcom Sub-task Resolved Paul Davies  

 Description   

Add support for validate-dcom



 Comments   
Comment by Anissa Lam [ 23/Nov/11 ]

There will not be a specific page to support the validate-dcom command.
However, before create any DCOM node, this command will be called first, so that if there is error will report to the user before calling the create node.
If it is fine, DCOM node will be created.

Comment by Anissa Lam [ 30/Nov/11 ]

GUI support will be in when backend deliver this.

Comment by Anissa Lam [ 02/Dec/11 ]

When creating DCOM node, added the checkbox to allow user to run validate-dcom first before creating the node.
Also provide text box to specify the remotetestdir.
but there seems to be a bug in the backend regarding password, so as of now, this validate-dcom always failed.as





[GLASSFISH-17606] The class javax.el.BeanELResolver causes a memoryLeak when application is redeployed Created: 03/Nov/11  Updated: 28/May/14  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: jsf
Affects Version/s: 3.1
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: obdulin Assignee: kchung
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7


Issue Links:
Dependency
blocks JAVASERVERFACES-3291 Memory Leak Closed

 Description   

We're using a custom EL Resolver in our application. This resolver returns instances of our own extention of UINamingContainer. Since the class BeanELResolver stores references to these classes in a CuncurrentHashMap (called properties) without wrapping them in a weakreference we have a classloader memory leak.

The application classloader, which loads our application UINamingContainer object, gets a reference from the class BeanELResolver (through the classes stored in the properties HashMap). The class BeanELResolver is loaded by the server classloader so when the application is undeployed (and the application classloader unreferred) there's still an alive reference to the application classloader and that causes the classloader memory leak (along with every single static member loaded by any class loaded by that same classloader)

ApplicationClassLoader <- UINaminContainerClass <- properties HashMap <- BeanELResolver <- ServerClassLoader

The BeanELResolver should either use weakreferences for the keys in the CuncurrentHashMap or choose a different key that doesn't imply references to other classloader's classes



 Comments   
Comment by Bhavanishankar [ 03/Nov/11 ]

Although this issue showed up while using embedded GlassFish, this does not look like an embedded specific issue.

Comment by rogerk [ 03/Nov/11 ]

javax.el.BeanResolver is a component (class ) of el.
However I do not see an "el" component to set in the JIRA issue.

Comment by kchung [ 30/Nov/11 ]

Fixed and integrated in glassfish.





[GLASSFISH-17552] Add support for install and uninstall node, for both dcom and ssh node. Created: 01/Nov/11  Updated: 02/Dec/11  Resolved: 02/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin_gui
Affects Version/s: None
Fix Version/s: 3.1.2_b13, 3.1.2

Type: New Feature Priority: Critical
Reporter: Anissa Lam Assignee: Anissa Lam
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
GLASSFISH-17792 OLH: modify the create-node and edit ... Sub-task Resolved Paul Davies  
Status Whiteboard:

cli-parity


 Description   

For better user experience, GUI should provide the capability to install and uninstall ssh and dcom node.



 Comments   
Comment by Anissa Lam [ 30/Nov/11 ]

remove the dependency. We will not call the install/uninstall command directly, instead will use the --archive option in the install-node command. Thus no longer depend on the install-node and uninstall-node being a remote command.

Comment by Anissa Lam [ 02/Dec/11 ]

All the intended support has checked in.
In Creating Node page,

  • dropdown type now has "DCOM" as the choice
  • added the "install" and "archive" option. User can specify the path to the .zip file or use the file chooser to select one.
  • added DCOM section for specifying all the options for DCOM node.
  • provide the option of doing 'validate-dcom' before creating DCOM node.

As of now, this validate-dcom node always failed about the password. So, try creating without validate-dcom first.





[GLASSFISH-17544] With Introspect enabled for JavaDB-30 , Derby-30 Oracle Datasource Classnames are also displayed. Created: 01/Nov/11  Updated: 25/Jan/12  Resolved: 06/Dec/11

Status: Closed
Project: glassfish
Component/s: jdbc
Affects Version/s: 3.1.2_b01
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: shaline Assignee: Shalini
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OS:Windows 2008 server
GF 3.1.2 b07
Firefox 3.6


Tags: 3_1_2-review, 3_1_2-verified

 Description   

In GF 3.1.2 b07, when we enable "introspect" for a JDBC pool with Database Driver Vendor" name as Derby-30 or JavaDB-30 or Embedded-Derby-30, and any value as "Resource Type", and then select "Next " button. In the next page, the List of Datasource Classnames displayed in the drop-down, has the Classnames for both Oracle and Derby db's. Even for the Driver Classnames , we see the Oracle Drivers listed along with Derby drivers.



 Comments   
Comment by shaline [ 01/Nov/11 ]

To reproduce this issue, place the Oracle ojdbc6.jar under domain1/lib dir and restart domain.
Then create a pool with Java-DB or Derby-DB where in Datasource Classnames for both Derby and Oracle are displayed. For JavaDB or DerbyDB without "-30" option, the Datasource Classnames are displayed correctly.

Comment by sumasri [ 16/Nov/11 ]

I could reproduce the issue.. But, the values are coming from back end.. Hence, Transferring it to Shalini from JDBC team.

Data source class names displaying for the condition dbVendor=JavaDB-30&introspect=true&resType=javax.sql.DataSource are

  • oracle.jdbc.pool.OracleConnectionPoolDataSource
  • oracle.jdbc.pool.OracleDataSource
  • oracle.jdbc.xa.client.OracleXADataSource
  • org.apache.derby.jdbc.ClientConnectionPoolDataSource
  • org.apache.derby.jdbc.ClientDataSource
  • org.apache.derby.jdbc.ClientXADataSource
  • org.apache.derby.jdbc.EmbeddedConnectionPoolDataSource
  • org.apache.derby.jdbc.EmbeddedDataSource
  • org.apache.derby.jdbc.EmbeddedSimpleDataSource
  • org.apache.derby.jdbc.EmbeddedXADataSource
Comment by sumasri [ 21/Nov/11 ]

Assigning it to JDBC team.Hence, modified the component.

Comment by Shalini [ 01/Dec/11 ]

Users who use admin console for introspection are affected by this bug when different versions of derby are used in the database vendor name. Fix is available for this issue. The GUI jdbc connection pool page should be unit tested with different options for database vendor name for verification of this issue.

Comment by Shalini [ 06/Dec/11 ]

Fixed in trunk.

Sending appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/connectors/util/DriverLoader.java
Transmitting file data .
Committed revision 51292.

Comment by Shalini [ 06/Dec/11 ]

Fixed in 3.1.2.

Sending connectors/connectors-runtime/src/main/java/com/sun/enterprise/connectors/util/DriverLoader.java
Transmitting file data .
Committed revision 51296.

Comment by shaline [ 25/Jan/12 ]

verified in GF 3.1.2 b18.





[GLASSFISH-17524] Expose setup-ssh as a remote command Created: 28/Oct/11  Updated: 11/Dec/11  Resolved: 01/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin
Affects Version/s: 3.1.1, 4.0
Fix Version/s: 3.1.2_b13, 4.0

Type: Improvement Priority: Major
Reporter: Joe Di Pol Assignee: Yamini K B
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Dependency
blocks GLASSFISH-17736 Support setup-ssh in GUI Resolved
Tags: 3_1_2-review

 Description   

The admin console wants to support setup-ssh capability. In order to do this we need to expose the local setup-ssh command as a remote admin command. It is acceptable to have this be an internal command, "_setup-ssh".



 Comments   
Comment by Yamini K B [ 01/Dec/11 ]

New command _setup-ssh checked in
3.1.2: r51232
Trunk: r51233

Comment by Yamini K B [ 06/Dec/11 ]

Refactored the command, r51311

Comment by Yamini K B [ 11/Dec/11 ]

Code refactored in trunk as well: r51402





[GLASSFISH-17516] OGS zip distributions should be configured to require admin password to be set at first domain start Created: 27/Oct/11  Updated: 05/Dec/11  Resolved: 05/Dec/11

Status: Resolved
Project: glassfish
Component/s: packaging
Affects Version/s: 4.0
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: Joe Di Pol Assignee: Snjezana Sevo-Zenzerovic
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Dependency
depends on GLASSFISH-17514 start-domain must prompt for a new ad... Resolved
blocks GLASSFISH-17510 Be more rigorous about requiring user... Resolved
Tags: 3_1_2-review

 Description   

Issue GLASSFISH-17514 describes the need for start-domain to optionally prompt when a domain is started the first time. In order to support this the OGS zip distributions must be constructed in such a fashion as to require the user to enter an admin password when the domain is first started.

The proposed mechanism for implementing this is to specify a magic token as the admin user's password hash in the admin-keyfile. Details can be found in GLASSFISH-17514.

This bug covers the modifications we need to make to the construction of the default domain in the OGS zip distributions to trigger this behavior (basically copy in a specially constructed admin-keyfile).



 Comments   
Comment by Snjezana Sevo-Zenzerovic [ 05/Dec/11 ]

OGS distribution assembly modified to include reset flag. Fix will be available in 3.1.2 b13.





[GLASSFISH-17511] Use of "new String(byte[] b, String env)" hist Sun JVM bottleneck Created: 27/Oct/11  Updated: 05/Dec/11  Resolved: 02/Dec/11

Status: Closed
Project: glassfish
Component/s: web_container
Affects Version/s: None
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: Shing Wai Chan Assignee: Shing Wai Chan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

This is a performance issue.
The issue has been filed in Tomcat: https://issues.apache.org/bugzilla/show_bug.cgi?id=51400

The same need to be fixed in GlassFish.



 Comments   
Comment by kchung [ 30/Nov/11 ]

I've applied the patch to PageDataImpl.java, SmapUtil.java, and should be in glassfish when JSP is integrated.

Comment by Shing Wai Chan [ 01/Dec/11 ]

fix in 3.1.2
Sending web/web-core/src/main/java/org/apache/catalina/authenticator/BasicAuthenticator.java
Sending web/web-core/src/main/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Sending web/web-core/src/main/java/org/apache/catalina/connector/Request.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/ByteArrayOutputStream.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/PartItem.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/RequestItemIterator.java
Sending web/web-core/src/main/java/org/apache/catalina/servlets/WebdavServlet.java
Sending web/web-core/src/main/java/org/apache/catalina/ssi/SSIFilter.java
Sending web/web-core/src/main/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
Sending web/web-core/src/main/java/org/apache/catalina/util/Base64.java
Sending web/web-core/src/main/java/org/apache/catalina/util/RequestUtil.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/PEAccessLogValve.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/ProxyHandlerImpl.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/pwc/connector/coyote/PwcCoyoteRequest.java
Sending web/web-ha/src/main/java/org/glassfish/web/ha/session/management/CompositeMetadata.java
Sending web/web-naming/pom.xml
Sending web/web-naming/src/main/java/org/apache/naming/Util.java
Sending web/web-naming/src/main/java/org/apache/naming/resources/ProxyDirContext.java
Transmitting file data ..................
Committed revision 51216.

Comment by Shing Wai Chan [ 01/Dec/11 ]

fix in 3.1.2 for CTS httpservletrequestsetCharacterEncodingUnsupportedEncodingExceptionTest
Sending web-core/src/main/java/org/apache/catalina/connector/Request.java
Sending web-core/src/main/java/org/apache/catalina/fileupload/ByteArrayOutputStream.java
Sending web-core/src/main/java/org/apache/catalina/fileupload/PartItem.java
Sending web-core/src/main/java/org/apache/catalina/util/RequestUtil.java
Transmitting file data ....
Committed revision 51239.

Comment by Shing Wai Chan [ 02/Dec/11 ]

Sending web/web-core/src/main/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Sending web/web-core/src/main/java/org/apache/catalina/connector/Request.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/ByteArrayOutputStream.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/PartItem.java
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/RequestItemIterator.java
Sending web/web-core/src/main/java/org/apache/catalina/servlets/WebdavServlet.java
Sending web/web-core/src/main/java/org/apache/catalina/ssi/SSIFilter.java
Sending web/web-core/src/main/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
Sending web/web-core/src/main/java/org/apache/catalina/util/Base64.java
Sending web/web-core/src/main/java/org/apache/catalina/util/RequestUtil.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/PEAccessLogValve.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/ProxyHandlerImpl.java
Sending web/web-glue/src/main/java/com/sun/enterprise/web/pwc/connector/coyote/PwcCoyoteRequest.java
Sending web/web-ha/src/main/java/org/glassfish/web/ha/session/management/CompositeMetadata.java
Sending web/web-naming/pom.xml
Sending web/web-naming/src/main/java/org/apache/naming/Util.java
Sending web/web-naming/src/main/java/org/apache/naming/resources/ProxyDirContext.java

Revision: 51257

Comment by Shing Wai Chan [ 05/Dec/11 ]

additional change due to API change from http://java.net/jira/browse/GRIZZLY-1141
Sending web/web-core/src/main/java/org/apache/catalina/fileupload/RequestItemIterator.java
Sending web/web-core/src/main/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
Sending web/web-core/src/main/java/org/apache/catalina/util/RequestUtil.java
Sending web/web-naming/src/main/java/org/apache/naming/Util.java
Transmitting file data ....
Committed revision 51275.





[GLASSFISH-17493] javax.servlet in 3.1.2 should reference the latest version from maven central Created: 26/Oct/11  Updated: 09/Dec/11  Resolved: 09/Dec/11

Status: Resolved
Project: glassfish
Component/s: packaging
Affects Version/s: 3.1.2_b01
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: Shing Wai Chan Assignee: Snjezana Sevo-Zenzerovic
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-approved

 Description   

Per discussion with Jane, if we don't adopt the new javax jar scheme in 3.1.2 workspace, javax.servlet artifact will have a new groupId, "org.glassfish.main.web" in maven.java.net (e.g. https://maven.java.net/content/repositories/snapshots/org/glassfish/main/web/javax.servlet/).
The new groupId is breaking OSGi compliance tests.



 Comments   
Comment by Shing Wai Chan [ 26/Oct/11 ]
  • What is the impact on the customer of the bug (is it a regression? which of the criteria does it meet?) No.
  • How likely is it that a customer will see the bug? No.
  • How long will it take you to implement the fix?
  • How risky is the fix? Low
  • Do regression tests exist for this issue to verify the fix? No
  • Which tests should QA (re)run to verify the fix did not destabilize GlassFish? run web tier tests
  • Which is the targeted build of 3.1.2 for this fix? b08
Comment by Shing Wai Chan [ 27/Oct/11 ]

Sending admin/jmx-remote/client/pom.xml
Sending admin/jmx-remote/common/pom.xml
Sending admin/jmx-remote/server/pom.xml
Sending admingui/common/pom.xml
Sending admingui/pom.xml
Sending admingui/war/pom.xml
Sending common/container-common/pom.xml
Sending common/glassfish-ee-api/pom.xml
Sending deployment/dol/pom.xml
Sending javaee-api/javax.javaee/pom.xml
Sending pom.xml
Sending security/core/pom.xml
Sending security/inmemory.jacc.provider/pom.xml
Sending security/jaspic-provider-framework/pom.xml
Sending security/javax.security.jacc/pom.xml
Sending security/webintegration/pom.xml
Sending security/webservices.security/pom.xml
Sending web/pom.xml
Sending web/war-util/pom.xml
Sending web/web-core/pom.xml
Sending web/web-embed/api/pom.xml
Sending web/web-glue/pom.xml
Transmitting file data ......................
Committed revision 50513.

Deleting javax.servlet

Committed revision 50514.

Comment by Sanjeeb Sahoo [ 27/Oct/11 ]

I am reopening this bug to make sure there is no javax.servlet.jar in the modules. I now see both javax.servlet-api.jar and javax.servlet.jar in modules.

Comment by Shing Wai Chan [ 27/Oct/11 ]

This is the same issue as in trunk. The flashlight referencing the web-glue in 3.1.1 which references the old javax.servlet.
So, we need to apply the same packager change in 3.1.2.

Comment by Snjezana Sevo-Zenzerovic [ 09/Dec/11 ]

Issue is now fully fixed, javax.servlet.jar has been excluded from 3.1.2 packaging.





[GLASSFISH-17429] jspc does not support JDK 7 Created: 14/Oct/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: web_container
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: pjiricka Assignee: kchung
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Mac OS X 10.7.2, JDK 7 Preview


Tags: 3_1_2-review

 Description   

1. Consider the following JSP page:
<%@page import="java.util.ArrayList"%>
<%@page import="java.util.List"%>
<%@page contentType="text/html" pageEncoding="UTF-8"%>
<!DOCTYPE html>
<html>
<body>
<% List<String> l = new ArrayList<>(); %>
</body>
</html>

2. To compile it using jspc, you need to run this command: jspc -uriroot web -d build -compile -compilerSourceVM 1.7

However, the command fails with an exception:

Exception in thread "main" java.lang.IllegalArgumentException: PWC6309: Illegal compilerSourceVM: 1.7
at org.apache.jasper.JspC.setCompilerSourceVM(JspC.java:712)
at org.apache.jasper.JspC.setArgs(JspC.java:398)
at org.apache.jasper.JspC.main(JspC.java:318)



 Comments   
Comment by pjiricka [ 14/Oct/11 ]

This was originally reported against NetBeans, see bug https://netbeans.org/bugzilla/show_bug.cgi?id=201414.

Comment by kchung [ 30/Nov/11 ]

Fixed.





[GLASSFISH-17339] file locking on windows is back Created: 23/Sep/11  Updated: 30/Nov/11  Resolved: 30/Nov/11

Status: Resolved
Project: glassfish
Component/s: web_container
Affects Version/s: 3.1.1_b12
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Critical
Reporter: vince kraemer Assignee: kchung
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

windows 7, jdk 7


Attachments: Java Archive File jar-lock-demo.jar    
Tags: 3_1_2-review

 Description   

Here are the steps to reproduce the issue...

S:\Users\vbk\Downloads>jar xvf jar-lock-demo.jar
created: META-INF/
inflated: META-INF/MANIFEST.MF
created: JarLockDemo/
created: JarLockDemo/build/
created: JarLockDemo/build/empty/
created: JarLockDemo/build/generated-sources/
created: JarLockDemo/build/generated-sources/ap-source-output/
created: JarLockDemo/build/web/
inflated: JarLockDemo/build/web/index.jsp
created: JarLockDemo/build/web/META-INF/
inflated: JarLockDemo/build/web/META-INF/MANIFEST.MF
created: JarLockDemo/build/web/WEB-INF/
created: JarLockDemo/build/web/WEB-INF/classes/
created: JarLockDemo/build/web/WEB-INF/lib/
inflated: JarLockDemo/build/web/WEB-INF/lib/jstl.jar
inflated: JarLockDemo/build/web/WEB-INF/lib/standard.jar
inflated: JarLockDemo/build.xml
created: JarLockDemo/dist/
inflated: JarLockDemo/dist/JarLockDemo.war
created: JarLockDemo/nbproject/
inflated: JarLockDemo/nbproject/ant-deploy.xml
inflated: JarLockDemo/nbproject/build-impl.xml
inflated: JarLockDemo/nbproject/genfiles.properties
created: JarLockDemo/nbproject/private/
inflated: JarLockDemo/nbproject/private/private.properties
inflated: JarLockDemo/nbproject/project.properties
inflated: JarLockDemo/nbproject/project.xml
created: JarLockDemo/src/
created: JarLockDemo/src/conf/
inflated: JarLockDemo/src/conf/MANIFEST.MF
created: JarLockDemo/src/java/
created: JarLockDemo/web/
inflated: JarLockDemo/web/index.jsp
created: JarLockDemo/web/WEB-INF/

S:\Users\vbk\Downloads>"s:\P F\glassfish-3.1.1\bin\asadmin" deploy JarLockDemo\build\web
Application deployed with name web.
Command deploy executed successfully.

S:\Users\vbk\Downloads>start iexplore.exe http://127.0.0.1:8080/web

S:\Users\vbk\Downloads>"s:\P F\glassfish-3.1.1\bin\asadmin" undeploy web
Command undeploy executed successfully.

S:\Users\vbk\Downloads>del JarLockDemo\build\web\WEB-INF\lib\jstl.jar
S:\Users\vbk\Downloads\JarLockDemo\build\web\WEB-INF\lib\jstl.jar
The process cannot access the file because it is being used by another process.

S:\Users\vbk\Downloads>"s:\P F\glassfish-3.1.1\bin\asadmin" version
Version = GlassFish Server Open Source Edition 3.1.1 (build 12)
Command version executed successfully.

S:\Users\vbk\Downloads>java -version
java version "1.7.0"
Java(TM) SE Runtime Environment (build 1.7.0-b147)
Java HotSpot(TM) Client VM (build 21.0-b17, mixed mode, sharing)

This is the root cause of https://netbeans.org/bugzilla/show_bug.cgi?id=202419

Any productive development workflow will use directory deployment so this is more than a 'NetBeans problem' or an IDE problem.



 Comments   
Comment by Hong Zhang [ 23/Sep/11 ]

Assign to Tim to take a look as he has more experience with this.

Comment by Tim Quinn [ 23/Sep/11 ]

As with any file locking problem, step 1 is to identify what code is locking it, which is relatively easy using the tool and instructions here:

http://blogs.oracle.com/quinn/entry/tool_for_diagnosing_failed_glassfish

Using that, I found out that it seems to be part of Jasper invoked from the web container that is opening the JAR (see the stack trace below).

So I am transferring this to the web container team.

Current list of opened but unclosed jar files matching the filter:
Path "/Users/Tim/asgroup/bugs/17339-fileLocking/JarLockDemo/build/web/WEB-INF/lib/jstl.jar"
..Opened by hashCode object 566 from:
java.util.jar.JarFile.<init>(java/util/jar/JarFile.java:137)
java.util.jar.JarFile.<init>(java/util/jar/JarFile.java:72)
sun.net.www.protocol.jar.URLJarFile.<init>(sun/net/www/protocol/jar/URLJarFile.java:72)
sun.net.www.protocol.jar.URLJarFile.getJarFile(sun/net/www/protocol/jar/URLJarFile.java:48)
sun.net.www.protocol.jar.JarFileFactory.get(sun/net/www/protocol/jar/JarFileFactory.java:55)
sun.net.www.protocol.jar.JarURLConnection.connect(sun/net/www/protocol/jar/JarURLConnection.java:104)
sun.net.www.protocol.jar.JarURLConnection.getJarFile(sun/net/www/protocol/jar/JarURLConnection.java:71)
java.net.JarURLConnection.getManifest(java/net/JarURLConnection.java:217)
org.apache.jasper.runtime.TldScanner.addManifestClassPath(org/apache/jasper/runtime/TldScanner.java:749)
org.apache.jasper.runtime.TldScanner.scanJars(org/apache/jasper/runtime/TldScanner.java:687)
org.apache.jasper.runtime.TldScanner.scanTlds(org/apache/jasper/runtime/TldScanner.java:350)
org.apache.jasper.runtime.TldScanner.onStartup(org/apache/jasper/runtime/TldScanner.java:239)
org.apache.catalina.core.StandardContext.callServletContainerInitializers(org/apache/catalina/core/StandardContext.java:5467)
com.sun.enterprise.web.WebModule.callServletContainerInitializers(com/sun/enterprise/web/WebModule.java:581)
org.apache.catalina.core.StandardContext.start(org/apache/catalina/core/StandardContext.java:5363)
com.sun.enterprise.web.WebModule.start(com/sun/enterprise/web/WebModule.java:498)
org.apache.catalina.core.ContainerBase.addChildInternal(org/apache/catalina/core/ContainerBase.java:917)
org.apache.catalina.core.ContainerBase.addChild(org/apache/catalina/core/ContainerBase.java:901)
org.apache.catalina.core.StandardHost.addChild(org/apache/catalina/core/StandardHost.java:733)
com.sun.enterprise.web.WebContainer.loadWebModule(com/sun/enterprise/web/WebContainer.java:2000)
com.sun.enterprise.web.WebContainer.loadWebModule(com/sun/enterprise/web/WebContainer.java:1651)
com.sun.enterprise.web.WebApplication.start(com/sun/enterprise/web/WebApplication.java:109)
org.glassfish.internal.data.EngineRef.start(org/glassfish/internal/data/EngineRef.java:130)
org.glassfish.internal.data.ModuleInfo.start(org/glassfish/internal/data/ModuleInfo.java:269)
org.glassfish.internal.data.ApplicationInfo.start(org/glassfish/internal/data/ApplicationInfo.java:294)
com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(com/sun/enterprise/v3/server/ApplicationLifecycle.java:462)
com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(com/sun/enterprise/v3/server/ApplicationLifecycle.java:240)
org.glassfish.deployment.admin.DeployCommand.execute(org/glassfish/deployment/admin/DeployCommand.java:382)
com.sun.enterprise.v3.admin.CommandRunnerImpl$1.execute(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:355)
com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:370)
com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:1064)
com.sun.enterprise.v3.admin.CommandRunnerImpl.access$1200(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:96)
com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:1244)
com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(com/sun/enterprise/v3/admin/CommandRunnerImpl.java:1232)
com.sun.enterprise.v3.admin.AdminAdapter.doCommand(com/sun/enterprise/v3/admin/AdminAdapter.java:459)
com.sun.enterprise.v3.admin.AdminAdapter.service(com/sun/enterprise/v3/admin/AdminAdapter.java:209)
com.sun.grizzly.tcp.http11.GrizzlyAdapter.service(com/sun/grizzly/tcp/http11/GrizzlyAdapter.java:168)
com.sun.enterprise.v3.server.HK2Dispatcher.dispath(com/sun/enterprise/v3/server/HK2Dispatcher.java:117)
com.sun.enterprise.v3.services.impl.ContainerMapper.service(com/sun/enterprise/v3/services/impl/ContainerMapper.java:238)
com.sun.grizzly.http.ProcessorTask.invokeAdapter(com/sun/grizzly/http/ProcessorTask.java:828)
com.sun.grizzly.http.ProcessorTask.doProcess(com/sun/grizzly/http/ProcessorTask.java:725)
com.sun.grizzly.http.ProcessorTask.process(com/sun/grizzly/http/ProcessorTask.java:1019)
com.sun.grizzly.http.DefaultProtocolFilter.execute(com/sun/grizzly/http/DefaultProtocolFilter.java:225)
com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(com/sun/grizzly/DefaultProtocolChain.java:137)
com.sun.grizzly.DefaultProtocolChain.execute(com/sun/grizzly/DefaultProtocolChain.java:104)
com.sun.grizzly.DefaultProtocolChain.execute(com/sun/grizzly/DefaultProtocolChain.java:90)
com.sun.grizzly.http.HttpProtocolChain.execute(com/sun/grizzly/http/HttpProtocolChain.java:79)
com.sun.grizzly.ProtocolChainContextTask.doCall(com/sun/grizzly/ProtocolChainContextTask.java:54)
com.sun.grizzly.SelectionKeyContextTask.call(com/sun/grizzly/SelectionKeyContextTask.java:59)
com.sun.grizzly.ContextTask.run(com/sun/grizzly/ContextTask.java:71)
com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(com/sun/grizzly/util/AbstractThreadPool.java:532)
com.sun.grizzly.util.AbstractThreadPool$Worker.run(com/sun/grizzly/util/AbstractThreadPool.java:513)
java.lang.Thread.run(java/lang/Thread.java:680)

Comment by Shing Wai Chan [ 09/Oct/11 ]

Accordng to Tim's analysis, the following code lock the file:
org.apache.jasper.runtime.TldScanner.addManifestClassPath(org/apache/jasper/runtime/TldScanner.java:749)

Comment by vince kraemer [ 27/Oct/11 ]

another path to this issue... https://netbeans.org/bugzilla/show_bug.cgi?id=204320

Comment by vince kraemer [ 28/Oct/11 ]

kchung... it has been a couple weeks. Do you have an update on the status of fixing this?

Comment by kchung [ 30/Oct/11 ]

This isuue has been fixed in JSP project and the artifacts puplished (org.glassfish.web:javax.servlet.jsp) but has not been integrated into glassfish. There was a weired osgi error when I started the server. I'll track it down when I come back from my vacation 11/15.

Comment by kchung [ 30/Nov/11 ]

Fixed





[GLASSFISH-17265] The task checking idle connections is scheduled using previous idleTimeout value on reconfiguration Created: 01/Sep/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: jdbc
Affects Version/s: 4.0
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: ito_m Assignee: Shalini
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Tags: 3_1_2-review

 Description   

When changing idletimeout after initialization of JDBC connection pool, the reconfiguration of pool is executed.
In this case, I expected the task checking idle connections would adopt the updated idletimeout value.
However it still seems to use the previous idletimeout value after reconfiguration.

[Reproducible steps]

  1. asadmin set resources.jdbc-connection-pool.DerbyPool.pooling=true
    asadmin set resources.jdbc-connection-pool.DerbyPool.steady-pool-size=8
    asadmin set resources.jdbc-connection-pool.DerbyPool.idle-timeout-in-seconds=10
  2. Getting a connection using DerbyPool. (DerbyPool is initialized on first getConnection().)
  3. asadmin set resources.jdbc-connection-pool.DerbyPool.idle-timeout-in-seconds=30
  4. Sleep 20 (sec)
  5. Idle connections are destroyed though idletimeout is 30 (sec).

Note that I couldn't always reproduce this issue by following the above steps. It might depend on the machine spec. So I confirmed the previous idletimeout value was passed Timer for ResizerTask directly on debug.

[Reason]
A variable idletime which is used in scheduleResizerTask() is not updated as follows.

com.sun.enterprise.resource.pool.ConnectionPool.java
public synchronized void reconfigurePool(ConnectorConnectionPool poolResource) throws PoolingException {
    int _idleTime = Integer.parseInt(poolResource.getIdleTimeoutInSeconds())
            * 1000;
    if (poolInitialized) {
        if (_idleTime != idletime && _idleTime != 0) {
            scheduleResizerTask();//idletime was not updated
        }
        if (_idleTime == 0) {
            //resizerTask.cancel();
            cancelResizerTask();
        }
    }
    idletime = _idleTime;//idletime will be updated here
    ...
}

private void scheduleResizerTask() {
    ...
    timer.scheduleAtFixedRate(resizerTask, idletime, idletime);// the previous idletime was passed 
    ...
}

I tested using GFv3.2(r48897).



 Comments   
Comment by Shalini [ 06/Dec/11 ]

Fixed in trunk.

Sending appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Sending appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/UnpooledResource.java
Transmitting file data ..
Committed revision 51293.

Comment by Shalini [ 06/Dec/11 ]

Fixed in 3.1.2

Sending connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Sending connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/UnpooledResource.java
Transmitting file data ..
Committed revision 51297.





[GLASSFISH-17263] GUI should give appropriate access denied msg Created: 31/Aug/11  Updated: 20/Jan/12  Resolved: 30/Nov/11

Status: Closed
Project: glassfish
Component/s: admin_gui
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13

Type: Bug Priority: Major
Reporter: Anissa Lam Assignee: Jason Lee
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Tags: 3_1_2-review, 3_1_2-verified

 Description   

secure admin needs to be enabled to allow user to use the Admin Console remotely.
The enforcement is checked in since in r49138 trunk, r49145 branch.
However, when access is denied, console always shows login error. Without differentiating whether it is login error or access denied.

In AdminConsoleAuthModule,
we should be able to distinguish the response by calling restResp.getResponseCode(). If it is 401, need to display a login page. If it is 403, let user know that remote access is denied.



 Comments   
Comment by Tim Quinn [ 30/Nov/11 ]

For what it's worth, the AdminAdapter (which handles asadmin requests) returns the top-level message in the ActionReport (which is in the HTTP response payload) as "Remote configuration is currently disabled"

Maybe the console adapter can do the same? I'm not sure what the console does with the ActionReport message, if anything.

Just a thought.

Ideally, the adapter that's providing the response status will set a useful message, rather than the client having to assume that 403 always means that remote config is turned off. That might be valid today, but that could change.

Comment by Jason Lee [ 30/Nov/11 ]

Fix committed to branch (r51210) and trunk (r51211).

Comment by shaline [ 20/Jan/12 ]

Verified in GF 3.1.2 b18.





[GLASSFISH-17262] Reconfiguration on unpooling causes NullPointerException Created: 31/Aug/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: jdbc
Affects Version/s: 4.0
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: ito_m Assignee: Shalini
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Attachments: Zip Archive GF17262.zip    
Tags: 3_1_2-review

 Description   

When increasing steady-pool-size dynamically after getting connections from unpooling JDBC connection pool, ConnectorRuntimeException occurred because of NullPointerException on creating a new connection. Unpooling JDBC connection pool should not be affected by steady-pool-size because the container must not have any pooled connections. I think the problem is that UnpooledResource.reconfigurePool() just delegates ConnectionPool.reconfigurePool().

[Reproducible steps]
1. asadmin set resources.jdbc-connection-pool.DerbyPool.pooling=false
2. asadmin set resources.jdbc-connection-pool.DerbyPool.steady-pool-size=8
3. Getting connections using DerbyPool.
4. asadmin set resources.jdbc-connection-pool.DerbyPool.steady-pool-size=9

[server.log]
[#|2011-08-31T15:31:07.060+1000|SEVERE|glassfish3.2|LogStrings.org.glassfish.resources|_ThreadID=43;_ThreadName=Thread-2;|resources.resource-manager.change-event-failed
com.sun.appserv.connectors.internal.api.ConnectorRuntimeException
at com.sun.enterprise.connectors.service.ConnectorConnectionPoolAdminServiceImpl.updateMCFAndPoolAttributes(ConnectorConnectionPoolAdminServiceImpl.java:1275)
at com.sun.enterprise.connectors.service.ConnectorConnectionPoolAdminServiceImpl.reconfigureConnectorConnectionPool(ConnectorConnectionPoolAdminServiceImpl.java:1221)
at com.sun.enterprise.connectors.ConnectorRuntime.reconfigureConnectorConnectionPool(ConnectorRuntime.java:878)
at com.sun.enterprise.resource.deployer.JdbcConnectionPoolDeployer.redeployResource(JdbcConnectionPoolDeployer.java:784)
at org.glassfish.resources.ResourceManager$PropertyChangeHandler.handleChangeEvent(ResourceManager.java:382)
at org.glassfish.resources.ResourceManager$PropertyChangeHandler.changed(ResourceManager.java:332)
at org.jvnet.hk2.config.ConfigSupport.sortAndDispatch(ConfigSupport.java:332)
at org.glassfish.resources.ResourceManager.changed(ResourceManager.java:277)
at org.jvnet.hk2.config.Transactions$ConfigListenerJob.process(Transactions.java:400)
at org.jvnet.hk2.config.Transactions$ConfigListenerJob.process(Transactions.java:390)
at org.jvnet.hk2.config.Transactions$ConfigListenerNotifier$1$1.call(Transactions.java:280)
at org.jvnet.hk2.config.Transactions$ConfigListenerNotifier$1$1.call(Transactions.java:278)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)

#]

[StackTrace when NullPointerException occurs]
UnpooledResource(ConnectionPool).createSingleResource(ResourceAllocator) line: 907
UnpooledResource(ConnectionPool).createResource(ResourceAllocator) line: 1185
RWLockDataStructure.addResource(ResourceAllocator, int) line: 98
UnpooledResource(ConnectionPool).addResource(ResourceAllocator) line: 282
UnpooledResource(ConnectionPool).createResourceAndAddToPool(ResourceAllocator) line: 1501
UnpooledResource(ConnectionPool).increaseSteadyPoolSize(int) line: 1491
UnpooledResource(ConnectionPool).reconfigurePool(ConnectorConnectionPool) line: 1425
PoolManagerImpl.reconfigPoolProperties(ConnectorConnectionPool) line: 674
ConnectorConnectionPoolAdminServiceImpl.updateMCFAndPoolAttributes(ConnectorConnectionPool) line: 1273
ConnectorConnectionPoolAdminServiceImpl.reconfigureConnectorConnectionPool(ConnectorConnectionPool, Set) line: 1221
ConnectorRuntime.reconfigureConnectorConnectionPool(ConnectorConnectionPool, Set) line: 878
JdbcConnectionPoolDeployer.redeployResource(Object) line: 784
ResourceManager$PropertyChangeHandler.handleChangeEvent(T) line: 382
ResourceManager$PropertyChangeHandler.changed(TYPE, Class<T>, T) line: 332

[line:907 of ConnectionPool]
protected ResourceHandle createSingleResource(ResourceAllocator resourceAllocator) throws PoolingException {
...
resourceHandle = resourceAllocator.createResource();//L907: resourceAllocator is null when UnpooledResource.reconfigurePool() is called.
...
}

I tested using GFv3.2(r48897).



 Comments   
Comment by ito_m [ 31/Aug/11 ]

The attached zip file is a reproducible application.

1. unzip the attached zip file to trunk\v2\appserv-tests\devtests directory
2. cd trunk\v2\appserv-tests\devtests\issues\GF17262
3. asadmin start-domain
4. asadmin start-database
5. ant prepare
6. ant run-unpool
7. check server.log of DAS.

Comment by Shalini [ 06/Dec/11 ]

Fixed in trunk.

Sending appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Sending appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/UnpooledResource.java
Transmitting file data ..
Committed revision 51293.

Comment by Shalini [ 06/Dec/11 ]

Fixed in 3.1.2.

Sending connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Sending connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/UnpooledResource.java
Transmitting file data ..
Committed revision 51297.





[GLASSFISH-17211] DB2 datasource classname is incorrect Created: 19/Aug/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: jdbc
Affects Version/s: 3.1_b43
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: dspurl Assignee: Shalini
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

windows server 2008 r2


Tags: 3_1_2-review, DB2, connectionpool

 Description   

There is a problem with the datasource classname that is generated after selecting the javax.sql.ConnectionPoolDataSource resource type. The datasource classname that automatically generated by glassfish is com.ibm.db2.jdbc.DB2ConnectionPoolDataSource when it should be COM.ibm.db2.jdbc.DB2ConnectionPoolDataSource. COM should be all caps.



 Comments   
Comment by Jagadish [ 29/Aug/11 ]

transferring to Shalini

Comment by Shalini [ 01/Dec/11 ]

The datasource classname that is generated by the database vendor mapping in glassfish should contain the right classname. Else, any operation pertaining to the jdbc driver might fail. Fix is available for this issue.

Comment by Shalini [ 06/Dec/11 ]

Fixed in trunk.

Sending appserver/jdbc/templates/src/main/resources/glassfish/lib/install/databases/dbvendormapping/cpds.properties
Transmitting file data .
Committed revision 51288.

Comment by Shalini [ 06/Dec/11 ]

Fixed in 3.1.2.

Sending jdbc/templates/src/main/resources/glassfish/lib/install/databases/dbvendormapping/cpds.properties
Transmitting file data .
Committed revision 51294.





[GLASSFISH-17159] Validation failure after getting connection from DataSource causes connection leak Created: 08/Aug/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: jdbc
Affects Version/s: 4.0
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Major
Reporter: ito_m Assignee: Shalini
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Attachments: Text File avoidleakcon.patch    
Tags: 3_1_2-review

 Description   

The ManagedConnectionFactory#createManagedConnection method of jdbc-ra calls the validateAndSetIsolation method after acquiring connections from DataSource.
The validateAndSetIsolation method is a role of connection validation and initializing transaction isolation level. If any errors occur in the validateAndSetIsolation method, it will be returned to connector runtime without closing the acquired connection. This indicates the possibility of connection leak.

Attached patch is to resolve this leak issue by calling the ManagedConnection#destroy method to close a physical connection. If connection close also fail after applying this patch, the following message will be printed in server.log.

[#|$

{Time}

|WARNING|glassfish3.2|javax.enterprise.resource.resourceadapter.com.sun.gjc.spi|$

{ThreadID}

;$

{ThreadName}

;|RAR5083 : Exception while destroying physical connection
java.sql.SQLException: $

{A message in SQLException}

at com.sun.gjc.spi.ManagedConnection.destroy(ManagedConnection.java:405)
at com.sun.gjc.spi.CPManagedConnectionFactory.createManagedConnection(CPManagedConnectionFactory.java:161)
at com.sun.enterprise.resource.allocator.LocalTxConnectorAllocator.createResource(LocalTxConnectorAllocator.java:87)
...



 Comments   
Comment by Shalini [ 01/Dec/11 ]

There could be a potential connection leak if the creation of new physical connection to the underlying EIS resource manager fails for some reason. This needs to be fixed. Fix is available for this issue.

Comment by Shalini [ 06/Dec/11 ]

Fixed in trunk.

Sending appserver/jdbc/admin/src/main/java/org/glassfish/jdbc/admin/cli/JDBCConnectionPoolManager.java
Sending appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/common/LocalStrings.properties
Sending appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/DMManagedConnectionFactory.java
Sending appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionFactory.java
Transmitting file data ....
Committed revision 51289.

Comment by Shalini [ 06/Dec/11 ]

Fixed in 3.1.2.

Sending jdbc/admin/src/main/java/org/glassfish/jdbc/admin/cli/JDBCConnectionPoolManager.java
Sending jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/common/LocalStrings.properties
Sending jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/DMManagedConnectionFactory.java
Sending jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionFactory.java
Transmitting file data ....
Committed revision 51295.





[GLASSFISH-16964] [OSGi] Unable to use SLF4J 1.6.x Created: 06/Jul/11  Updated: 07/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: cdi
Affects Version/s: 3.1, 3.1.1_b09, 3.1.2
Fix Version/s: 3.1.2_b13, 4.0

Type: Bug Priority: Critical
Reporter: ancoron Assignee: Sivakumar Thyagarajan
Resolution: Fixed Votes: 5
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

weld-osgi-bundle 1.1.1.Final


Attachments: File MANIFEST.MF    
Issue Links:
Dependency
blocks GLASSFISH-17460 Embedded V3 dev tests are getting fail Resolved
Duplicate
duplicates GLASSFISH-17213 conflicting versions of slf4j bundled... Resolved
duplicates GLASSFISH-17171 Glassfish 3.1.2_01 Java EE 6 RI Bug - Resolved
is duplicated by GLASSFISH-17246 SLF4J API conflicts with org.glassfis... Resolved
Tags: 3_1_1-scrubbed, 3_1_2-review, 3_1_next, weld-int-required

 Description   

Because of a slight API change in SLF4J I am unable to use version 1.6.x because the "weld-osgi-bundle" doesn't play well with it:

WARNING: Failed to deploy bundle com.something.support.web [319]
org.glassfish.osgijavaeebase.DeploymentException: Deployment of com.something.support.web [319] failed because of following reason: Failed while deploying bundle com.something.support.web [319] : \
    java.lang.RuntimeException: Failed to deploy bundle [ com.something.support.web [319] ], \
    root cause: Exception while loading the app
	at org.glassfish.osgijavaeebase.AbstractOSGiDeployer.deploy(AbstractOSGiDeployer.java:125)
	at org.glassfish.osgijavaeebase.OSGiContainer.deploy(OSGiContainer.java:154)
	at org.glassfish.osgijavaeebase.JavaEEExtender.deploy(JavaEEExtender.java:107)
	at org.glassfish.osgijavaeebase.JavaEEExtender.access$200(JavaEEExtender.java:61)
	at org.glassfish.osgijavaeebase.JavaEEExtender$HybridBundleTrackerCustomizer$1.call(JavaEEExtender.java:151)
	at org.glassfish.osgijavaeebase.JavaEEExtender$HybridBundleTrackerCustomizer$1.call(JavaEEExtender.java:148)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.RuntimeException: Failed to deploy bundle [ com.something.support.web [319] ] \
    , root cause: Exception while loading the app
	at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.deploy(OSGiDeploymentRequest.java:196)
	at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.execute(OSGiDeploymentRequest.java:118)
	at org.glassfish.osgijavaeebase.AbstractOSGiDeployer.deploy(AbstractOSGiDeployer.java:121)
	... 10 more
Caused by: java.lang.NoSuchMethodError: org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker; \
    Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
	at org.slf4j.cal10n.LocLogger.info(LocLogger.java:122)
	at org.jboss.weld.bootstrap.WeldBootstrap.<clinit>(WeldBootstrap.java:213)
	at org.glassfish.weld.WeldDeployer.load(WeldDeployer.java:345)
	at org.glassfish.weld.WeldDeployer.load(WeldDeployer.java:99)
	at org.glassfish.internal.data.ModuleInfo.load(ModuleInfo.java:186)
	at org.glassfish.internal.data.ApplicationInfo.load(ApplicationInfo.java:257)
	at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:461)
	at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:240)
	at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.deploy(OSGiDeploymentRequest.java:183)
	... 12 more

So obviously weld is not compatible with SLF4J 1.6.x and hence should not be wired to such a version.

I already filed an upstream issue:

https://issues.jboss.org/browse/WELD-932



 Comments   
Comment by Sanjeeb Sahoo [ 08/Jul/11 ]

Assigning to CDI team. Not much can be done in GlassFish other than waiting for the bug to be fixed in Weld and integrating the same in GlassFish.

Comment by jthoennes [ 08/Jul/11 ]

Will this be fixed for GF v3.1.1?

Comment by Sivakumar Thyagarajan [ 08/Jul/11 ]

No, it will not be fixed for 3.1.1, as we have integrated Weld 1.1.1.Final in this release. The upstream Weld issue has not been fixed in 1.1.1.Final. Thanks.

Comment by Ganesh Krishnan [ 11/Aug/11 ]

I found a workaround by deleting the 1.5.x slf4j jar files from the root of glassfish and copying in 1.6.x version of slf4j jar files. Took me the whole day to debug and come to the conclusion that the method signature of the slf4j has changed in the new version. Bad logger! no cookie for you

Comment by Sanjeeb Sahoo [ 30/Aug/11 ]

A patched MANIFEST.MF which restricts the org.slf4j.* import-package version range to [1.5.0, 1.6.0). To apply, do the following:
cp glassfish/modules/weld-osgi-bundle.jar /tmp/weld-osgi-bundle.jar.orig
jar uvfm glassfish/modules/weld-osgi-bundle.jar MANIFEST.MF

You will see a few warnings as this attached MANIFEST.MF has all the attributes which are already present in the jar, but they can be ignored. Now, restart glassfish. Hope this helps until the upstream weld bug is fixed and a new version of weld is integrated in GlassFish.

Comment by cinhtau [ 30/Aug/11 ]

I can confirm this issue. I use slf4j-api-1.6.2 and logback-classic-0.9.29. Maybe this is an duplicate issue http://java.net/jira/browse/GLASSFISH-17246 then.

Comment by Sanjeeb Sahoo [ 30/Aug/11 ]

It is indeed a duplicate of GLASSFISH-17246. Have marked them as such now.

cinhtau,
I know you have worked around by using some other log api, but I will appreciate much if you can try the patched MANIFEST.MF and confirm if it works.

thanks.

Comment by cinhtau [ 30/Aug/11 ]

Confirm patch: Apply patch. It's working deployment and CDI with weld performs ok. Log routing to SLF4J and logback is working.

Comment by Cheng Fang [ 28/Oct/11 ]

Any updates? ejb devtests (ejb31/embedded/embedasync) are still failing with GlassFish 3.1.2 due to this issue.

Comment by Bhavanishankar [ 05/Nov/11 ]

This issue is very important for Embedded GlassFish

Comment by ancoron [ 12/Nov/11 ]

Upgrade to weld 1.1.3.SP1 and everything should be fine.

Comment by kshitiz_saxena [ 06/Dec/11 ]

With latest weld integration 1.1.4.Final, this issue is no longer reproducible.

Cheng verified that testcase is working on latest build.

Marking this issue as resolved.

Comment by ancoron [ 07/Dec/11 ]

Thank you very much!





[GLASSFISH-16248] Implement Windows alternative to SSH Created: 22/Mar/11  Updated: 06/Dec/11  Resolved: 06/Dec/11

Status: Resolved
Project: glassfish
Component/s: distributed management
Affects Version/s: 3.1
Fix Version/s: 3.1.2_b13

Type: Improvement Priority: Critical
Reporter: Joe Di Pol Assignee: Byron Nevins
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Dependency
blocks GLASSFISH-17624 add support for validate-dcom Resolved
Tags: 3_1_2-review, dcom

 Description   

We currently require an SSH service to be installed on Windows to support SSH nodes. So that means a customer must install and configure Cygwin sshd or MKS ssh service.

It would be good if we had a more Windows friendly solution. A couple possibilities:

1) Provide our own SSHD service written in Java that is easy to configure and run. Apache Mina SSHD could be an option in this area.

2) Use DCOM. Some possible DCOM Java libraries to consider:
J-interop: http://www.j-interop.org/
Jcifs: http://jcifs.samba.org/



 Comments   
Comment by Tom Mueller [ 06/Apr/11 ]

Good to have for 3.2

Comment by Byron Nevins [ 03/May/11 ]

Umbrella RFE

Comment by scatari [ 06/Dec/11 ]

With DHQA of DCOM support complete as of 3.1.2 B13, I am marking this RFE as fixed.





[GLASSFISH-16034] possibility to forbid create-local-instance to create new instances in node-config Created: 17/Feb/11  Updated: 13/Dec/11  Resolved: 13/Dec/11

Status: Resolved
Project: glassfish
Component/s: admin
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2_b13, 4.0

Type: Improvement Priority: Major
Reporter: schaarsc Assignee: Joe Di Pol
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

we create domains using these steps:
create-domain
create-node-config(s)
create-cluster
create-instance(s)

it would be useful to have a property in node-config which would prevent creating new instances using create-local-instance.
by "new" I mean, not previously created/declared by create-instance. This would avoid unwanted instances created by accident e.g. misspelled instance-name



 Comments   
Comment by Joe Di Pol [ 11/Mar/11 ]

We have received a couple requests from customers for the ability to disable instance creation at the node and/or cluster level. So that once their instances are created they would like to have a mechanism to prevent future accidental instance creation.

Comment by Joe Di Pol [ 13/Dec/11 ]

Implemented in 3.1.2 branch

Project:    glassfish
Repository: svn
Revision:   51394
Author:     jfdipol
Date:       2011-12-09 01:06:12 UTC
Link:       

Log Message:
------------
16034 forbid create-local-instance to create new instances in node-config
7025067 (bugster) provide option to avoid changes to cluster topologies

This adds a "freeze" attribute to the <node> and <nodes> elements.
If the attribute is true on a <node> then instance creation on that
node is not allowed. If the attribute is true on <nodes> then new node
creation is not allowed.

Currently you must use the "set" command to set this attribute.
For example:

asadmin set nodes.freeze=true
asadmin set nodes.node.<node-name>.freeze=true

Revisions:
----------
51394

Modified Paths:
---------------
branches/3.1.2/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/LocalStrings.properties
branches/3.1.2/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Node.java
branches/3.1.2/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Nodes.java
branches/3.1.2/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Server.java

Comment by Joe Di Pol [ 13/Dec/11 ]

Fixed in trunk: r51545





Generated at Sat Jul 30 01:57:18 UTC 2016 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.