GlassFish services and components to conform with configuration modularity (GLASSFISH-19408)

[GLASSFISH-19522] Diagnostic service configuration to conform with configuration modularity Created: 11/Jan/13  Updated: 20/Dec/16

Status: Reopened
Project: glassfish
Component/s: admin
Affects Version/s: None
Fix Version/s: 4.0_dev

Type: Sub-task Priority: Major
Reporter: Masoud Kalali Assignee: tvlatas
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Comment by tvlatas [ 16/Jan/13 ]

I grabbed the changes that were listed for removing the DiagnosticService from the templates and reproduced the admin dev test failures here.

I took a look and the problem with the changes is that there apparently is also a which relies on both the order and existence of elements in the domain templates.

When I removed the createDiagnosticServiceConfig(defaultConfig); from the postConstruct() these tests passed.

I'm not familiar with that code, so I don't know if removing that call will have other side effects, so I may find other issues as I test this out.

Comment by tvlatas [ 18/Jan/13 ]

quick update on the testing.

The admin dev tests for upgrade are failing for me with the above mentioned change I made, but they appear to be unrelated to my change and looks more like those tests don't run properly on JDK 7:

[java] Exception in thread "main" MultiException stack 1 of 2
[java] java.lang.UnsupportedClassVersionError: com/sun/enterprise/admin/cli/optional/BackupDomainCommand : Unsupported major.minor version 51.0
[java] at java.lang.ClassLoader.defineClass1(Native Method)
[java] at java.lang.ClassLoader.defineClass(
[java] at
[java] at

Comment by tvlatas [ 18/Jan/13 ]

Found the problem the issue was that while the JAVA_HOME was set, the PATH was still finding an older version of the JDK (so thus the mismatch).

Setting the path to the JDK 1.7 and rerunning the tests passed.

I'm going to rerun the full set locally, but it looks like this change should be OL.

Comment by tvlatas [ 01/Feb/13 ]

Revision 58967 was committed to address this

Comment by tvlatas [ 01/Feb/13 ]

In reviewing the one-pager for config modularity, I believe that the original set of changes the config team had listed to resolve this on their wiki was insufficient. It only addressed the domain defaults.

The DiagnosticService configuration allows extensions, and the pattern for that is changing, so we also need to review and update to align with the new pattern/annotations there now as well.

Generated at Sun Feb 26 03:31:58 UTC 2017 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.