Here is some more feedback on PR:
- In this code:
@Resource(name = "concurrent/myFactory")
newThread returns a Thread instead of ManageableThread. Shouldn't it return the later ?
- Shouldn't ManageableThread inherit from java.lang.Thread ?
- How are ManageableThreadFactory and ManagedExecutorService use cases different ? I can create bunch of threads from the former and create my own thread pool or executor service.
- IMHO ManagedThread is a better name than ManageableThread.
- There is a default ManagedThreadFactory. Should it be in the concurrent namespace, i.e.
- Will the code:
be equivalent to:
[jsr236-spec users] Some more feedback on PR