Skip to main content

Source code revision

svn

summary: IT 10918
revision: 34152
author: bnevins
date: 2009-11-10 01:01:12 UTC (6 years)
message: IT 10918

The "isHidden" feature was obviously committed too early (by me).

It would throw a RuntimeException which went all the way back to
MonitoringBootstrap -- whenever a "hidden" probe was discovered.

I.e. it was a routine and normal occurrence yet it was treated like an error.

Fix:

2 things --

1. if it is hidden do NOT add it as a DTrace listener to the probe -- handle it
QUIETLY and uneventfully.

2. If *all* the methods in a PP are hidden -- then don't even create the DTrace
class.

I tested manually and everything looks good.
Tests:
JDK6 - V3 - DTrace turned off on Solaris10 --> no problems, QL passed
JDK6 - V3 - DTrace turned on on Solaris10 --> no problems
glassfish-dtrace copied to modules dir and JDK7 runtime setup
JDK7 - V3 - glassfish-dtrace copied to modules DTrace turned off on Solaris10 --> no problems
JDK7 - V3 - DTrace turned on on Solaris10 --> no problems - works!

Change Path Actions
M trunk/v3/flashlight/framework/src/main/java/org/glassfish/flashlight/impl/provider/DTraceMethodFinder.java
M trunk/v3/flashlight/framework/src/main/java/org/glassfish/flashlight/impl/provider/FlashlightProbeProviderFactory.java
 
 
Close
loading
Please Confirm
Close