Skip to main content

Source code revision

svn

summary: Fix for 15963
revision: 45067
author: tjquinn
date: 2011-02-11 22:59:25 UTC (6 years)
message: Fix for 15963

Work done earlier to help optimize synchronization of uploaded archives to remote instances introduced a bug which broke the .reload feature. Files uploaded during deployment are placed into a temporary directory under the domain's applications directory. The code at fault incorrectly assumed that a file anywhere under the domain's applications directory was an uploaded file. Deployment expands all archives and, except for the sync feature, the uploaded archive is no longer needed. So the code moved what it thought was the uploaded file to a separate directory for use by synchronization. But when a user touches the .reload file in the applications/(appName) directory for an already-deployed app, that directory is within the applications directory so this logic was moving the expanded directory to this separate directory, causing rather some havoc.

This change repairs the problem by not moving a file under the applications directory if it is itself a directory. This is the lowest-risk fix at this point in 3.1.

Approved: Nazrul
Reviewed: Hong
Tests: QL, deployment devtests including a new test for the .reload feature
Change Path Actions
M branches/3.1/deployment/admin/src/main/java/org/glassfish/deployment/admin/DeployCommand.java
 
 
Close
loading
Please Confirm
Close