Skip to main content

Re: HK2-59 changes review

  • From: Romain Grécourt <romain.grecourt@...>
  • To: dev@...
  • Subject: Re: HK2-59 changes review
  • Date: Fri, 01 Feb 2013 01:49:56 +0100

Great! ps: Iaroslav's is "yaroska".

Le 31/01/13 20:22, John Wells a écrit :
The changes look good to me as well. I am going to promote hk2 today, so this change will probably be in the next promotion.

On 1/31/2013 12:37 PM, Mahesh.Kannan@... wrote:
The changes look fine to me. Could you also run web and ejb dev tests with your changes?

BTW, I was working on this bug and have made some progress on the hk2-config module (but hadn't converted the apt module). Didn't know that you were working on this.


On 1/31/13 9:19 AM, Iaroslav Savytskyi wrote:

I've replaced APT dependency in HK2 with JSR 269 implementation.

Also I've removed JAXB-XJC dependency.

This changes was tested with GF build and GF quicklook tests. I've compared several generated files with old ones and they are identical. Please review.

If the changes are OK I will need the commit rights on hk2 project.



Re: HK2-59 changes review

Mahesh.Kannan@... 01/31/2013

Re: HK2-59 changes review

John Wells 01/31/2013

Re: HK2-59 changes review

Romain Grécourt 01/31/2013
Please Confirm