Skip to main content

[pkg-discuss] Re: [review] fix for pkg list -u

  • From: Saurabh Vyas < >
  • To: Shawn Walker < >
  • Cc:
  • Subject: [pkg-discuss] Re: [review] fix for pkg list -u
  • Date: Tue, 26 Mar 2013 11:26:45 +0530

On 03/26/13 05:49, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issue:

16547544 get_pkg_list(LIST_UPGRADABLE) can return packages without
newer versions

http://ips.java.net/webrev/srwalker/pkg-list-u/

-Shawn

Hi Shawn

This fix LGTM.
One small question on the test case :

1265 1280                  # Reset image state for following tests.
1281 + self.pkg("set-publisher -G '*' -g " + self.rurl1 + " test1")
     1282 +                self.pkg("set-publisher -p " + self.rurl2)

Here we are setting back 'self.rurl2' with '-p' (and not with -g)
any particular reason for that (I might be missing the obvious, but this
is just for my clarification).

Thanks,
Saurabh


[pkg-discuss] [review] fix for pkg list -u

Shawn Walker 03/26/2013

[pkg-discuss] Re: [review] fix for pkg list -u

Saurabh Vyas 03/26/2013

[pkg-discuss] Re: [review] fix for pkg list -u

Shawn Walker 03/26/2013
 
 
Close
loading
Please Confirm
Close