Skip to main content

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

  • From: Shawn Walker < >
  • To:
  • Subject: [pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements
  • Date: Mon, 10 Jun 2013 14:21:15 -0700

On 04/19/13 14:48, Shawn Walker wrote:
Greetings,

The following webrev contains changes for the following items:

   15654935 pkg facet/variant should also display those implicitly set
   16425698 pkg variant subcommand should not require "variant." prefix
   16689413 facet/variant subcommands should support wildcards
   16689420 pkg facet/variant should offer parsable output format
   16689425 pkg facet/variant should have a full test suite
   16694970 manifest facets/variants properties can raise misleading
            exception

http://ips.java.net/webrev/srwalker/pkg-facet-variant-1/

I've attempted to incorporate all review feedback:

  * facet/variant subcommand changes:
    - '-f' to '-a'
    - new '-v' option for showing possible variant values
    - strip 'facet.' and 'variant.' prefix from default output
  * more comments for change-facet/change-variant optimisations
  * variable naming changes
  * docstring updates for new functions
  * correctness fixes for manifest caching changes
  * more unit tests (unknown variant usage, etc.)

Incremental webrev (diff against 1st):

  https://ips.java.net/webrev/srwalker/pkg-facet-variant-1-vs-2/

Full webrev (all changes):

  https://ips.java.net/webrev/srwalker/pkg-facet-variant-2/

-Shawn


[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Edward Pilatowicz 06/01/2013

<Possible follow-up(s)>

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Shawn Walker 06/05/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Edward Pilatowicz 06/05/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Shawn Walker 06/06/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Bart Smaalders 06/07/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Shawn Walker 06/10/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Edward Pilatowicz 06/10/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Shawn Walker 06/10/2013

[pkg-discuss] Re: [review] pkg facet/variant subcommand enhancements

Edward Pilatowicz 06/10/2013
 
 
Close
loading
Please Confirm
Close