Skip to main content

[pkg-discuss] Re: [review] file overlay fixes

  • From: Shawn Walker < >
  • To:
  • Cc: Tim Foster < >
  • Subject: [pkg-discuss] Re: [review] file overlay fixes
  • Date: Tue, 11 Jun 2013 15:29:01 -0700

On 06/11/13 02:20, Tim Foster wrote:
hi Shawn,

Thanks for the reminder to look at these bits,

On 05/ 6/13 10:19 AM, Shawn Walker wrote:
The following webrev contains fixes for the following issues:

    16764165 overlay files may be removed unexpectedly during pkg
             operations
    16765529 preserve semantics ignored for overlay file updates

webrev:
    http://ips.java.net/webrev/srwalker/pkg-overlay-1/

The test cases are very important here.  If you see a missing
permutation, let me know.

src/modules/actions/file.py

line 486, line 560, line 566: could we have comments here explaining
what the '0' and '1' indexes are, or use a namedtuple, or point to
imageplan.py line 3086ish I think?   (urgh, smaller methods there would
be nice there to localise the search area when trying to refer to
sections of that code (not this bug though))

These have to be seralisable, so I can't use a namedtuple. I've added a comment.

Perhaps a comment on line 483 summarizing what "save_file" is, and where
it comes from would be enough.

Added comment.

I'm going to look at the tests in more detail tomorrow (my brain's a bit
fried, and I'd rather look at these when I'm fresh - sorry for the
further delay)

Thanks,
-Shawn


[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013
 
 
Close
loading
Please Confirm
Close