Skip to main content

[pkg-discuss] Re: [review] file overlay fixes

  • From: Tim Foster < >
  • To:
  • Cc: Shawn Walker < >
  • Subject: [pkg-discuss] Re: [review] file overlay fixes
  • Date: Wed, 12 Jun 2013 12:05:08 +1200

On 06/11/13 09:20 PM, Tim Foster wrote:
     http://ips.java.net/webrev/srwalker/pkg-overlay-1/

I'm going to look at the tests in more detail tomorrow (my brain's a bit
fried, and I'd rather look at these when I'm fresh - sorry for the
further delay)

I've gone through those tests, and they look pretty thorough. The only think I could think of that might be worth testing as well, is that when we attempt to install an overlay where the preserve action has not changed, that if the file/owner/group have changed, we do still reject the overlay.

[ we test for those conflicts on basic overlays at line 7775, but I wasn't sure whether these bugfixes have any impact on that functionality ]

eg.

7867    # Install overlaying package, then update overlaid package and
7868    # verify that file content does not change if only preserve
7869    # attribute changes.
7870    self.pkg("install -vvv unpreserved-overlayer")
7871    self.file_contains("etc/pam.conf", "unpreserved")
7872    self.pkg("install overlaid@1")
7873    self.file_contains("etc/pam.conf", "unpreserved")

# change permissions of tmp/file1
open overlaid@99,5.11-0
add dir path=etc mode=0755 owner=root group=root
add file tmp/file1 path=etc/pam.conf mode=755 owner=sys group=sys preserve=renamenew overlay=allow

Then check that installing this package at line 7874 fails:

self.pkg("install overlaid@99", exit=1)

and similar, when changing the permissions of the overlaying package.

        cheers,
                        tim



[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013
 
 
Close
loading
Please Confirm
Close