Skip to main content

[pkg-discuss] Re: [review] file overlay fixes

  • From: Tim Foster < >
  • To: Shawn Walker < >
  • Cc:
  • Subject: [pkg-discuss] Re: [review] file overlay fixes
  • Date: Wed, 12 Jun 2013 12:17:11 +1200

On 06/12/13 12:15 PM, Shawn Walker wrote:
On 06/11/13 17:05, Tim Foster wrote:
On 06/11/13 09:20 PM, Tim Foster wrote:
      http://ips.java.net/webrev/srwalker/pkg-overlay-1/

[ we test for those conflicts on basic overlays at line 7775, but I
wasn't sure whether these bugfixes have any impact on that functionality ]
.
.
That really falls under the standard conflict checking mechanism found
in imageplan.py:
So are you asking for a test where if both the 'overlay=allow' action
and the 'overlay=true' action change mode/owner/group but do not change
content that the content remains unchanged?  If so, that should be
covered already under test_file_preserve lines 2626-2646 in
t_pkg_install.py.

If you're concerned about the overlaying package having attributes that
don't match what's being overlaid, that should be covered by lines
7775-7777 in t_pkg_install.py.

Ok,

Not objecting, just want to be clear.

Right - all of the above. It sounds like the bugfixes here have no impact on the conflict-checking functionality, so there's no need to add tests if we're already doing the right thing (yay!)

Thanks for clarifying.

        cheers,
                        tim



[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/11/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Shawn Walker 06/12/2013

[pkg-discuss] Re: [review] file overlay fixes

Tim Foster 06/12/2013
 
 
Close
loading
Please Confirm
Close