Skip to main content

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

  • From: Thejaswini < >
  • To: ,
  • Subject: [pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.
  • Date: Thu, 27 Jun 2013 13:39:11 +0530

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Thanks again.<br>
    I have made the changes.<br>
    The new&nbsp; webrev is at
    <a class="moz-txt-link-freetext" href="https://ips.java.net/webrev/tk241774/15648766-3/";>https://ips.java.net/webrev/tk241774/15648766-3/</a>.<br>
    Also the build and all the test cases ran successfully.<br>
    <br>
    - Thejaswini K.<br>
    <div class="moz-signature">
      <title></title>
      <img src="cid:part1.07070703.00000502@oracle.com" alt="Oracle"
        height="30" width="110" border="0"><br>
      Thejaswini K<br>
      Revenue Product Engineering (RPE), Systems <br>
      Phone: +91 8067283833 | Mobile: +91 9663324594 <font size="2"
        color="#666666" face="Verdana, Arial, Helvetica, sans-serif"><br>
        ORACLE India | Off Langford Road | Bangalore | 560025 </font>
      <br>
      <a href="http://www.oracle.com/commitment"; target="_blank"><img
          src="cid:part2.06020907.00080403@oracle.com" alt="Green
          Oracle" align="middle" height="28" width="44" border="0"></a>
      <font size="1" color="#4b7d42" face="Verdana, Arial, Helvetica,
        sans-serif">Oracle is committed to developing practices and
        products that
        help protect the environment</font>
      <!-- This signature was generated by the MyDesktop Oracle Business Signature utility -->
    </div>
    <br>
    On 06/26/13 22:07, Bart Smaalders wrote:
    <blockquote cite="mid:
      " type="cite">On
      06/26/13 02:22, Thejaswini wrote:
      <br>
      <blockquote type="cite">Thanks Bart for taking a look.
        <br>
        <br>
        I have made the changes as suggested in the CR .
        <br>
        In addition I have made changes to handke the case "pkg list -u
        <br>
        fuzzy-wombats"
        <br>
        <br>
        The new webrev is at
        <a class="moz-txt-link-freetext" href="https://ips.java.net/webrev/tk241774/15648766-2/";>https://ips.java.net/webrev/tk241774/15648766-2/</a>
        <br>
      </blockquote>
      <br>
      <br>
      This looks much better, thanks.&nbsp; One nit:
      <br>
      <br>
      In the case where no matches are found, the
      <br>
      strings should have either 'is' or 'are' added;
      <br>
      e.g.:
      <br>
      <br>
      No package matching 'fuzzy-wombat' is installed
      <br>
      <br>
      or
      <br>
      <br>
      No packages matching 'fuzzy-wombat, 'hairy-wombat' are installed.
      <br>
      <br>
      Thanks...
      <br>
      <br>
      - Bart
      <br>
      <br>
    </blockquote>
  </body>
</html>

GIF image

GIF image



[pkg-discuss] Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/24/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Bart Smaalders 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Bart Smaalders 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/27/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Erik Trauschke 06/27/2013
 
 
Close
loading
Please Confirm
Close