Skip to main content

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

  • From: Erik Trauschke < >
  • To:
  • Cc: Thejaswini < >,
  • Subject: [pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.
  • Date: Thu, 27 Jun 2013 16:17:52 -0700



On 06/27/13 01:09 AM, Thejaswini wrote:
Thanks again.
I have made the changes.
The new  webrev is at https://ips.java.net/webrev/tk241774/15648766-3/.
Also the build and all the test cases ran successfully.

This still has some flaws. Check the following case:

# pkg list -u pkg core-os cookie-monster
pkg list: packages 'cookie-monster, pkg, core-os' are up-to-date.

What it should say is:
pkg list: packages 'pkg, core-os' are up-to-date, package 'cookie-monster' is not installed in the system.

Or something along these lines, the actual wording is not that important to me.

Erik


- Thejaswini K.
Oracle
Thejaswini K
Revenue Product Engineering (RPE), Systems
Phone: +91 8067283833 | Mobile: +91 9663324594
ORACLE India | Off Langford Road | Bangalore | 560025
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment

On 06/26/13 22:07, Bart Smaalders wrote:
On 06/26/13 02:22, Thejaswini wrote:
Thanks Bart for taking a look.

I have made the changes as suggested in the CR .
In addition I have made changes to handke the case "pkg list -u
fuzzy-wombats"

The new webrev is at https://ips.java.net/webrev/tk241774/15648766-2/


This looks much better, thanks.  One nit:

In the case where no matches are found, the
strings should have either 'is' or 'are' added;
e.g.:

No package matching 'fuzzy-wombat' is installed

or

No packages matching 'fuzzy-wombat, 'hairy-wombat' are installed.

Thanks...

- Bart



[pkg-discuss] Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/24/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Bart Smaalders 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Bart Smaalders 06/26/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Thejaswini 06/27/2013

[pkg-discuss] Re: Trivial code review req: 15648766 pkg list -u claims no such package installed when there are simply.

Erik Trauschke 06/27/2013
 
 
Close
loading
Please Confirm
Close