On 07/31/13 08:38, Erik Trauschke wrote:
On 07/31/13 12:02 AM, Thejaswini wrote:
includes fix for:
15678637 <https://bug.oraclecorp.com/show?15678637> SUNBT7133912
image-create and set-publisher only use last -p specified.
The change is trivial.
The fix is :
To exit pkg with a error message when user provides -p option >1 in
"pkg image-create" and "pkg set-publisher" command.
Please review the changes and let me know your comments.
Maybe rephrase to: "-p option can only be specified once"?
Yes; I'd ask Alta about the wording. It should be similar to what we'd use in
751, 752: I think it's not really necessary to actually create these
directories because you are just testing if the option-parsing code
fails. These directories are never evaluated.
Correct. No need to call mkdir().
The copyright year needs updating.
Also, the test logic should be moved into test_image_create_bad_opts(); it
doesn't need it's own unit test. You also don't need to check the error
Checking for exit=2 is sufficient.
[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.