Skip to main content

[pkg-discuss] Re: code review request: pkgdepend Python 3 support

  • From: Tim Foster < >
  • To:
  • Cc: Danek Duvall < >
  • Subject: [pkg-discuss] Re: code review request: pkgdepend Python 3 support
  • Date: Thu, 01 Aug 2013 17:07:12 +1200

On 07/30/13 06:50 AM, Danek Duvall wrote:
There's really not much to see here -- Python 3 support is essentially
identical to 2.7 support, except for a few small syntax changes.  I've
combined the multiple depthlimitedmfXY.py files back into depthlimitedmf.py
and it's not too too grotty, though there are some bits which need to be
copied.  Overall, though, I think it's a win for now.

     http://ips.java.net/webrev/dhduvall/pkgdepend3/

This looks good, so long as you've remembered to actually 'hg rm' the depthlimitedmf27.py.

After this change, given that depthlimitemf.py has to run with both Python 2 and Python 3, are there any automated checks that we can run during the build to ensure we're not reintroducing Python2 syntax nits?
[ 2to3 maybe? ]

Oh, thanks for fixing the crazy in base.py :-)

Brian's been testing this on Python 3 code, and it seems to work as well
(and as poorly) as it does on Python 2 code, so that seems to be enough.

That's a shame: I was hoping python3 was going to show some improvement on how modulefinder deals with relative imports, but Not This Bug (and I saw your update on that earlier)

        cheers,
                        tim



[pkg-discuss] Re: code review request: pkgdepend Python 3 support

Tim Foster 08/01/2013

[pkg-discuss] Re: code review request: pkgdepend Python 3 support

Danek Duvall 08/08/2013

<Possible follow-up(s)>

[pkg-discuss] Re: code review request: pkgdepend Python 3 support

Shawn Walker 08/19/2013
 
 
Close
loading
Please Confirm
Close