On 07/30/13 21:32, Thejaswini wrote:But then query like "pkg search pkg://pub1/pkg1" will list pkg1 present in all publishers.
The new webrev is @ http://ips.java.net/webrev/tk241774/15620551/rev04/
line 2674: This should be the same regex used in actions/depend.py
so that the publisher prefix will be stripped too.
You don't needI have made these changes and the webrev is at
to use the compile() logic described below though; just use the
existing re.sub() logic here.
line 319: Because this regex will be used multiple times,
it should be compiled into a RegexObject and then reused.
To do that, on line 314 (after the inds = ):
pat = re.compile(r"pkg:///|pkg://[^/]*/|pkg:/")
...and then on line 319:
p = pat.sub("", p)
line 1056, 1066, 1078: Add "-H" to the list of options.
lines 1052, 1063, 1072: drop these lines
lines 1060, 1069, 1081: s/assertEqual/assertEqualDiff/
line 1082: Insert another newline here
Otherwise, I think this is right.
[pkg-discuss] Re: Code review of pkg search bugs 15620551 and 16190165