Skip to main content

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

  • From: Yiteng Zhang < >
  • To:
  • Subject: [pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed
  • Date: Mon, 19 Aug 2013 14:07:02 -0700

On 08/15/13 01:11 PM, Erik Trauschke wrote:


On 08/15/13 11:16 AM, Yiteng Zhang wrote:
Hi,

The bug is at
https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=16851082

My code review can be seen:

http://ips.java.net/webrev/yitezhan/16851082/

In principle this goes into the right direction but there is still way more code to be converted.

For instance, 'pkg install -v <pkg>' will show a list of FMRIs which are going to change. The code for this is in __display_plan().
And there are probably a few other places where the output need changing.

I would go and look at how the display functions (in the files you already changed) retrieve their FMRIs and then look where else the same method of retrieval is used.

You can also have a look in the test suite and check which pkg applications get tested for an expected output that includes the build version.

Erik
Hi,
Thanks for you advice. My new code review can be seen at:
http://ips.java.net/webrev/yitezhan/16851082_2/

To demonstrate my modifications, please take a look at the following details.

To omit the build_release of the FMRI displays, I have modified the output of some of the pkg utilities command:

Command    Changed?(Y or N)     Detail
pkg Y pkg list -v pkg info pkg install --licenses pkg install -v pkg uninstall -v
pkgdepend              N
pkgrepo Y pkgrepo list -F tsv -s [repo] pkgrepo list -F json -s [repo]
pkgdiff                      N
pkgfmt                     N
pkglint                      N
pkgmerge                N
pkgmogrify              N
pkgsurf                   N
pkgsend                  N
pkgsign                   Y                    pkgsign -s [path_or_uri]
packagemanager    N
pkgrecv Y pkgrecv -s [src_repo_uri] --newest pkgrecv --clone

The reason why I didn't change some of them is because the commands do not take the FMRIs for displays.

I am looking forward to your comments. Thanks.

-Yiteng


[pkg-discuss] Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/15/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/15/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Shawn Walker 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/20/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/21/2013
 
 
Close
loading
Please Confirm
Close