Skip to main content

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

  • From: Yiteng Zhang < >
  • To: " " < >
  • Cc: Tim Foster < >
  • Subject: [pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed
  • Date: Mon, 19 Aug 2013 16:08:06 -0700

On 08/19/13 03:28 PM, Tim Foster wrote:
On 08/20/13 09:07 AM, Yiteng Zhang wrote:
http://ips.java.net/webrev/yitezhan/16851082_2/

To omit the build_release of the FMRI displays, I have modified the
output of some of the pkg utilities command:

Command    Changed?(Y or N)     Detail

pkglint                      N

pkglint displays full FMRIs frequently throughout, eg:

$ pkg contents -m core-os > core-os.mf
$ pkglint -v core-os.mf

Typically, it uses the __str__ method of PkgFmri, so I'm not sure what the best approach is. Certainly changing pkglint to call <PkgFmri>.get_fmri(include_build=False) would work, but that's a significant amount of work throughout its codebase.

pkglint also uses build_release in the (rarely used) "version.pattern" property in /usr/share/lib/pkg/pkglintrc.


Skipping pkglint until build_release goes away is probably a better option, but it depends on how strongly we want this to go away (personally, I'm not too bothered about it)

    cheers,
            tim

I will check the "pkg contents -m" first. Also, since there is a new changeset updated this afternoon, I need to fix some failures from the test scripts. Thanks.

Yiteng


[pkg-discuss] Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/15/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/15/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Tim Foster 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Shawn Walker 08/19/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/20/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Erik Trauschke 08/21/2013

[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed

Yiteng Zhang 08/21/2013
 
 
Close
loading
Please Confirm
Close