On 08/15/13 01:11 PM, Erik Trauschke wrote:
On 08/15/13 11:16 AM, Yiteng Zhang wrote:
The bug is at
My code review can be seen:
In principle this goes into the right direction but there is still way
more code to be converted.
For instance, 'pkg install -v <pkg>' will show a list of FMRIs which
are going to change. The code for this is in __display_plan().
And there are probably a few other places where the output need changing.
I would go and look at how the display functions (in the files you
already changed) retrieve their FMRIs and then look where else the
same method of retrieval is used.
You can also have a look in the test suite and check which pkg
applications get tested for an expected output that includes the build
Thanks for you advice. My new code review can be seen at:
To demonstrate my modifications, please take a look at the following
To omit the build_release of the FMRI displays, I have modified the
output of some of the pkg utilities command:
Command Changed?(Y or N) Detail
pkg Y pkg list -v pkg info
pkg install --licenses pkg install -v pkg uninstall -v
pkgrepo Y pkgrepo list -F tsv -s
[repo] pkgrepo list -F json -s [repo]
pkgsign Y pkgsign -s [path_or_uri]
pkgrecv Y pkgrecv -s [src_repo_uri]
--newest pkgrecv --clone
The reason why I didn't change some of them is because the commands do
not take the FMRIs for displays.
[pkg-discuss] Re: Review 16851082 - build_release (aka build version) should not be displayed