Skip to main content

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

  • From: Tim Foster < >
  • To:
  • Cc: Xiaobo Shen < >
  • Subject: [pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher
  • Date: Thu, 29 Aug 2013 09:09:23 +1200

Hi Xiabo,

On 08/29/13 08:59 AM, Xiaobo Shen wrote:
On 08/27/13 07:52 PM, Tim Foster wrote:
http://ips.java.net/webrev/xiaoshen/Bug_15771544_pkgrepo2/

Thanks a lot for your comments. I have fixed most of the issues.

Cool.

For the "rm -rf" subprocess, I am unsure if we can really avoid pub folder 
left
in the tmp folder by just using synchronous flag. I guess during the
system crashes, it is still possible to have something uncleaned in tmp
folder.

That's true, but at least the administrator knows that an operation was still in progress at the time of the crash/reboot, which is still better imho.

[ we could go to town and implement a transient SMF service that deletes itself once the publisher removal is finally completed, which would survive reboots, but that's overkill I think. ]

        cheers,
                        tim



[pkg-discuss] Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Tim Foster 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Tim Foster 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Erik Trauschke 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/29/2013
 
 
Close
loading
Please Confirm
Close