Skip to main content

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

  • From: Erik Trauschke < >
  • To:
  • Cc: Tim Foster < >, Xiaobo Shen < >
  • Subject: [pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher
  • Date: Wed, 28 Aug 2013 14:15:36 -0700



On 08/28/13 02:09 PM, Tim Foster wrote:
Hi Xiabo,

On 08/29/13 08:59 AM, Xiaobo Shen wrote:
On 08/27/13 07:52 PM, Tim Foster wrote:
http://ips.java.net/webrev/xiaoshen/Bug_15771544_pkgrepo2/

Thanks a lot for your comments. I have fixed most of the issues.

Cool.

For the "rm -rf" subprocess, I am unsure if we can really avoid pub
folder left
in the tmp folder by just using synchronous flag. I guess during the
system crashes, it is still possible to have something uncleaned in tmp
folder.

That's true, but at least the administrator knows that an operation was
still in progress at the time of the crash/reboot, which is still better
imho.

[ we could go to town and implement a transient SMF service that deletes
itself once the publisher removal is finally completed, which would
survive reboots, but that's overkill I think. ]

I haven't looked at the latest two webrevs yet but just about the rm in background:
Since the repo store gets moved to a location which should have a naming scheme like rm.<pubname>.<random_number> it is very obvious what that directory is about. So people can go and delete it they find it and feel it's necessary to do so.

Shawn and I even talked about other pkg tools being able to trigger removal of stuff in the tmp directory if necessary. I'm ok with a synchronous option but I think having it do the actual work in the background should be the default behavior.

Erik


[pkg-discuss] Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Tim Foster 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Tim Foster 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Erik Trauschke 08/28/2013

[pkg-discuss] Re: Review request 2 for 15771544 pkgrepo should have a way of removing an entire publisher

Xiaobo Shen 08/29/2013
 
 
Close
loading
Please Confirm
Close