[pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files
- From: Shawn Walker <
- Cc: Thejaswini <
- Subject: [pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files
- Date: Tue, 06 Aug 2013 14:47:24 -0700
On 08/02/13 02:44, Thejaswini wrote:
Another code review request.
The webrev is at: http://ips.java.net/webrev/tk241774/15814511/rev01/
The webrev has the fix for
Let me know your comments.
It's unfortunate that you had to indent all of that additional code;
this was already not pretty.
It seems like you could simplify this:
salvaged = api_inst.describe().salvaged
newbe = api_inst.describe().new_be
if salvaged and (rval == EXIT_OK or not newbe):
# Only show salvaged file list if populated and operation was
# successful, or if operation failed and a new BE was not
# created for the operation.
You could then revert all of the other changes.
Otherwise, this looks fine.