Skip to main content

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

  • From: Xiaobo Shen < >
  • To:
  • Subject: [pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version
  • Date: Fri, 30 Aug 2013 11:03:55 -0700

On 08/29/13 05:21 PM, Xiaobo Shen wrote:
On 08/29/13 04:51 PM, Erik Trauschke wrote:
On 08/29/13 04:37 PM, Xiaobo Shen wrote:
Hi guys,

please see the following link: thanks.
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo/

Have you tried to run the new test case without your fix and checked that it actually fails?
Because looking at your test case it doesn't seem like it would find that problem.
Ok. I fixed it and re-ran the test. the previous tests would never fail because it did not capture the bug.

link:
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo2/


Here is a enhanced version, which verifies human version is not displayed if identical with version number and the version is still displayed correctly.
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo3/

xiaobo



[pkg-discuss] Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/29/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/29/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013
 
 
Close
loading
Please Confirm
Close