Skip to main content

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

  • From: Xiaobo Shen < >
  • To: Erik Trauschke < >
  • Cc:
  • Subject: [pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version
  • Date: Fri, 30 Aug 2013 13:31:26 -0700

On 08/30/13 01:14 PM, Erik Trauschke wrote:


On 08/30/13 12:52 PM, Xiaobo Shen wrote:
On 08/30/13 11:14 AM, Erik Trauschke wrote:


On 08/30/13 11:03 AM, Xiaobo Shen wrote:
On 08/29/13 05:21 PM, Xiaobo Shen wrote:
On 08/29/13 04:51 PM, Erik Trauschke wrote:
On 08/29/13 04:37 PM, Xiaobo Shen wrote:
Hi guys,

please see the following link: thanks.
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo/

Have you tried to run the new test case without your fix and checked
that it actually fails?
Because looking at your test case it doesn't seem like it would find
that problem.
Ok. I fixed it and re-ran the test. the previous tests would never
fail because it did not capture the bug.

link:
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo2/


Here is a enhanced version, which verifies human version is not
displayed if identical with version number and the version is still
displayed correctly.
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo3/

tests/cli/t_pkg_info.py:
    Instead of using exit=1 you can just use "grep -v".

I would also rename the package to something else, 'humaniden' sounds
like some new kind of humanoid race they found at the bottom of the
ocean ;)
maybe human2 or human-ident.

Otherwise this looks good to me.

Erik
Cool. I updated the test by checking the actual output. "grep -v"
probably does not capture the bug, because it still produce some output.
Please see the following link:
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo6/

You can do that but you'd have to make sure the test is run in the correct locale, otherwise the dates pkg info prints might be in a different format.

Maybe the easiest way is grepping for "Version: 0.9.8.18$" (note the $)
This way it will fail if anything is printed after the 0.9.8.18.

Erik
great! changed and tested:
http://ips.java.net/webrev/xiaoshen/Bug_17355511_pkginfo7/

xiaobo


[pkg-discuss] Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/29/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/29/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Xiaobo Shen 08/30/2013

[pkg-discuss] Re: Review request 17355511 pkg info displays human-version even when identical to actual version

Erik Trauschke 08/30/2013
 
 
Close
loading
Please Confirm
Close