Skip to main content

[pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files

  • From: Thejaswini < >
  • To: , Shawn Walker < >
  • Subject: [pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files
  • Date: Wed, 07 Aug 2013 14:10:13 +0530


On 08/07/13 03:17, Shawn Walker wrote:
On 08/02/13 02:44, Thejaswini wrote:
Hi,

Another code review request.
The webrev is at: http://ips.java.net/webrev/tk241774/15814511/rev01/
The webrev has the fix for
https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=15814511

Let me know your comments.

src/client.py:
  It's unfortunate that you had to indent all of that additional code;
  this was already not pretty.

  It seems like you could simplify this:

  try:
    salvaged = api_inst.describe().salvaged
    newbe = api_inst.describe().new_be
    if salvaged and (rval == EXIT_OK or not newbe):
      # Only show salvaged file list if populated and operation was
      # successful, or if operation failed and a new BE was not
      # created for the operation.
      ....

   You could then revert all of the other changes.


Otherwise, this looks fine.
I have made these changes and the new webrev is @ http://ips.java.net/webrev/tk241774/15814511/rev02/.
If there are no more comments I will push these changes tomorrow.

Thanks,
Thejaswini K.

-Shawn


[pkg-discuss] Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files

Thejaswini 08/02/2013

[pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files

Shawn Walker 08/06/2013

[pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files

Thejaswini 08/07/2013

[pkg-discuss] Re: Code review request: 15814511 SUNBT7196723 pkg can traceback when displaying list of salvaged files

Shawn Walker 08/07/2013
 
 
Close
loading
Please Confirm
Close