On 08/07/13 01:46, Thejaswini wrote:
On 08/07/13 00:11, Shawn Walker wrote:
On 08/05/13 23:03, Thejaswini wrote:
The webrev http://ips.java.net/webrev/tk241774/case-search/rev01/
has fix for 16273625 <https://bug.oraclecorp.com/show?16273625>
case-insensitive search broken for specific queries.
The fix is only two line change in query_parser.py.
I ran the complete test-suite and all the test-cases pass.
Please review it and let me know your comments/suggestions.
line 1415: I see you added the call _close_dicts(), but
it's missing the important comment found on lines 1521-1522
that says why it is calling it.
line 1416: Add a newline after this
I have incorporated the above changes and the webrev is @
Yes it failed. Therefore I have added a assert statement to make sure
Does this test case fail without the changes to
there are no error messages thrown.
If there are no more comments I would push the changes tomorrow.
[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken