Skip to main content

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

  • From: Shawn Walker < >
  • To:
  • Cc: Thejaswini < >
  • Subject: [pkg-discuss] Re: Code review request:16273625 case-insensitive search broken
  • Date: Wed, 07 Aug 2013 11:39:57 -0700

On 08/07/13 11:32, Shawn Walker wrote:
On 08/07/13 01:46, Thejaswini wrote:

On 08/07/13 00:11, Shawn Walker wrote:
On 08/05/13 23:03, Thejaswini wrote:
Hi All,

The webrev http://ips.java.net/webrev/tk241774/case-search/rev01/
has fix for 16273625 <https://bug.oraclecorp.com/show?16273625>
case-insensitive search broken for specific queries.

The fix is only two line change in query_parser.py.

I ran the complete test-suite and all the test-cases pass.

Please review it and let me know your comments/suggestions.

src/modules/query_parser.py:
  line 1415: I see you added the call _close_dicts(), but
    it's missing the important comment found on lines 1521-1522
    that says why it is calling it.

  line 1416: Add a newline after this

I have incorporated the above changes and the webrev is @
http://ips.java.net/webrev/tk241774/case-search/rev02/

src/tests/cli/t_pkg_search.py:
  Does this test case fail without the changes to
src/modules/query_parser.py?
Yes it failed. Therefore I have added a assert statement to make sure
there are no error messages thrown.

If there are no more comments I would push the changes tomorrow.

Actually, the assert() doesn't make any sense.

I would expect self.errout to containg something if the commands exits with 1.

What does self.output and self.stderr contain at that point?

Does the test case actually succeed after you added the assert?

-Shawn



[pkg-discuss] Code review request:16273625 case-insensitive search broken

Thejaswini 08/06/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Shawn Walker 08/06/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Thejaswini 08/07/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Shawn Walker 08/07/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Shawn Walker 08/07/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Thejaswini 08/08/2013

[pkg-discuss] Re: Code review request:16273625 case-insensitive search broken

Shawn Walker 08/08/2013
 
 
Close
loading
Please Confirm
Close