Skip to main content

[pkg-discuss] Re: review for bug 16297554 pkg history fails when time travelling

  • From: Xiaobo Shen < >
  • To:
  • Subject: [pkg-discuss] Re: review for bug 16297554 pkg history fails when time travelling
  • Date: Thu, 08 Aug 2013 14:30:04 -0700

On 08/ 8/13 02:04 PM, Danek Duvall wrote:
Xiaobo Shen wrote:

http://ips.java.net/webrev/xiaoshen/16297554_history_time/
Mostly style nits:

   - line 5605: a continuation line should be indented further by four
     spaces.  You could avoid that entirely by using "+=", but on the other
     hand, should this string be i18n'ed?  If so, then string concatenation
     is probably not right -- you'd want to have something like

         output["finish"] = _("%s (clock drift detected)") % output["finish"]

   - Thanks for getting rid of lines with trailing spaces, but while you're
     doing that, you might as well get rid of the tabs on lines 3750, 3748,
     and 651.

Thanks,
Danek
Sounds reasonable. I'll fix them. Thanks.

xiaobo


[pkg-discuss] review for bug 16297554 pkg history fails when time travelling

Xiaobo Shen 08/08/2013

[pkg-discuss] Re: review for bug 16297554 pkg history fails when time travelling

Danek Duvall 08/08/2013

[pkg-discuss] Re: review for bug 16297554 pkg history fails when time travelling

Xiaobo Shen 08/08/2013

[pkg-discuss] Re: review for bug 16297554 pkg history fails when time travelling

Shawn Walker 08/09/2013
 
 
Close
loading
Please Confirm
Close