Skip to main content

[pkg-discuss] Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

  • From: Yiteng Zhang < >
  • To:
  • Subject: [pkg-discuss] Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant
  • Date: Fri, 09 Aug 2013 12:54:56 -0700

Hi guys,
I just fixed thsi bug and push my code review to the webrev. Please take a look on it.
    http://ips.java.net/webrev/yitezhan/16986557_prefix_1/

One thing to mention, after I run the test scripts, it reported some mismatches failures. It is because the test scripts still expect to see the output with prefixes. Thanks.

     Yiteng


[pkg-discuss] Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Yiteng Zhang 08/09/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Danek Duvall 08/09/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Shawn Walker 08/09/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Yiteng Zhang 08/10/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Shawn Walker 08/11/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Yiteng Zhang 08/12/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Edward Pilatowicz 08/12/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Erik Trauschke 08/12/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Edward Pilatowicz 08/12/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Shawn Walker 08/12/2013

[pkg-discuss] Re: Code review request for Bug 16986557 - prefixes should be omitted from output of facet and variant

Edward Pilatowicz 08/12/2013
 
 
Close
loading
Please Confirm
Close