Skip to main content

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

  • From: Erik Trauschke < >
  • To: Thejaswini < >
  • Cc: , Shawn Walker < >, Alta Elstad < >
  • Subject: [pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.
  • Date: Fri, 02 Aug 2013 16:23:28 -0700

On 08/ 1/13 10:19 PM, Thejaswini wrote:
I have changed the message to "The -p option can be specified only once"
and also incorporated other changes.
The latest webrev is at http://ips.java.net/webrev/tk241774/15678637/rev02/

_pkg_image_create.py, t_pkg_publisher.py:

I wouldn't even have used actual URLs for the publishers but it follows the way the other tests are set up, so I'm fine with it.

The rest looks alright to me.

Erik


[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Thejaswini 08/02/2013

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Erik Trauschke 08/02/2013

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Shawn Walker 08/02/2013
 
 
Close
loading
Please Confirm
Close