Skip to main content

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

  • From: Shawn Walker < >
  • To:
  • Cc: Thejaswini < >, Alta Elstad < >, Erik Trauschke < >
  • Subject: [pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.
  • Date: Fri, 02 Aug 2013 16:56:40 -0700

On 08/01/13 22:19, Thejaswini wrote:

On 07/31/13 23:07, Shawn Walker wrote:
On 07/31/13 10:28, Alta Elstad wrote:
On 07/31/13 09:55, Shawn Walker wrote:
On 07/31/13 08:38, Erik Trauschke wrote:

On 07/31/13 12:02 AM, Thejaswini wrote:
Hi

The webrevhttp://ips.java.net/webrev/tk241774/15678637/rev01/
includes fix for:

15678637 <https://bug.oraclecorp.com/show?15678637> SUNBT7133912
image-create and set-publisher only use last -p specified.

The change is trivial.
The fix is :
To exit pkg with a error message when user provides -p option >1 in
"pkg image-create" and "pkg set-publisher" command.

Please review the changes and let me know your comments.

client.py:

Maybe rephrase to: "-p option can only be specified once"?

Yes; I'd ask Alta about the wording. It should be similar to what we'd
use in a
man page.

Currently the man page has no prose statement about how many times -p
can be specified, either to set-publisher or image-create, as I'm sure
you are aware. Currently this is handled by not including ... in the
syntax. Are you suggesting such a statement is needed in the man page?

No, what I meant was the wording of this message itself.  If we were
to explicitly state which options were only expected once instead of
the reverse as we do now, how would we word it?

In the usage message, I think the above is fine, though I prefer
complete sentences if appropriate for a usage message: "The -p option
can be specified only one time."

Yes, that's what I was referring to :-)
I have changed the message to "The -p option can be specified only once"
and also incorporated other changes.
The latest webrev is at http://ips.java.net/webrev/tk241774/15678637/rev02/

This is fine except for the deletion of line 748 in src/tests/cli/t_pkg_image_create.py.

Revert that, and then you can push as far as I'm concerned.

-Shawn



[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Thejaswini 08/02/2013

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Erik Trauschke 08/02/2013

[pkg-discuss] Re: Code review request: 15678637 image-create and set-publisher only use last -p specified.

Shawn Walker 08/02/2013
 
 
Close
loading
Please Confirm
Close