Skip to main content

[pkg-discuss] Re: small code review for 17306428

  • From: Edward Pilatowicz < >
  • To: Shawn Walker < >
  • Cc:
  • Subject: [pkg-discuss] Re: small code review for 17306428
  • Date: Tue, 13 Aug 2013 17:11:50 -0700

On Tue, Aug 13, 2013 at 05:02:16PM -0700, Shawn Walker wrote:
> On 08/13/13 16:23, Edward Pilatowicz wrote:
> >hey all,
> >
> >seems my recent linked image facet inheritance wad broke facet
> >evaluations in some cases:
> >
> >     17306428 imageplan always finds change when facets are set
> >
> >i've updated the bug with an analysis and i've got a fix here:
> >
> >     https://ips.java.net/webrev/edp/17306428/
>
> I assume the test case fails without the fix? :-)
>

yep.

but triggering the failure (without the fix) seems some what
non-deterministic.  i found couldn't trigger it reliably just by setting
two facets like we discussed.  so i switched to using multiple random
facet values and i found that when i got to around 5 i would usually see
a failure.  so then to be safe i set the number of facets to test with
to 15.

ed


[pkg-discuss] small code review for 17306428

Edward Pilatowicz 08/13/2013

[pkg-discuss] Re: small code review for 17306428

Shawn Walker 08/13/2013

[pkg-discuss] Re: small code review for 17306428

Edward Pilatowicz 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Erik Trauschke 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Edward Pilatowicz 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Erik Trauschke 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Erik Trauschke 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Edward Pilatowicz 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Shawn Walker 08/14/2013

[pkg-discuss] Re: small code review for 17306428

Edward Pilatowicz 08/14/2013
 
 
Close
loading
Please Confirm
Close