Skip to main content

[pkg-discuss] [review] 17318601 pkg needs a synchronous option for service actuators

  • From: Erik Trauschke < >
  • To:
  • Subject: [pkg-discuss] [review] 17318601 pkg needs a synchronous option for service actuators
  • Date: Thu, 26 Sep 2013 17:53:38 -0700

This is a review request for

17318601 pkg needs a synchronous option for service actuators
https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=17318601

It adds an interface to the new SMF feature of synchronous svcadm commands including a timeout.
If the pkg client is used with --sync-actuators and --sync-actuators-timeout set to some value it will return with a new exit code (12) in case svcadm timed out.

So far I suuport install, update, uninstall, change-facet and change-variant. Let me know if you think more subcommands require an interface to this.

I opted to not use global variables but also didn't want to carry around two options to set this up. So I put all the information into one internal argument containing the timeout time in seconds. The value 0 means that we don't use synchronous actuators and -1 means we use an infinite timeout (or no timeout).

Webrev is here:
https://ips.java.net/webrev/etrausch/17318601_syncact/

Thanks
Erik


[pkg-discuss] [review] 17318601 pkg needs a synchronous option for service actuators

Erik Trauschke 09/27/2013

[pkg-discuss] Re: [review] 17318601 pkg needs a synchronous option for service actuators

Tim Foster 09/27/2013

[pkg-discuss] Re: [review] 17318601 pkg needs a synchronous option for service actuators

Erik Trauschke 09/27/2013
 
 
Close
loading
Please Confirm
Close