[pkg-discuss] Re: [review] 17318601 pkg needs a synchronous option for service actuators
- From: Tim Foster <
- Subject: [pkg-discuss] Re: [review] 17318601 pkg needs a synchronous option for service actuators
- Date: Fri, 27 Sep 2013 14:23:06 +1200
I had a look at this.
On 09/27/13 12:53 PM, Erik Trauschke wrote:
17318601 pkg needs a synchronous option for service actuators
So far I support install, update, uninstall, change-facet and
change-variant. Let me know if you think more subcommands require an
interface to this.
I wonder would it be worth including a synchronous refresh of the
system-repository as part of set-publisher by default.
I don't think there's a need to add an option to 'set-publisher' for
this, but it seems to make sense that we should have the
system-repository service immediately reflect the publisher
configuration of the GZ. See line 682 of src/modules/client/image.py -
having it use synchronous SMF commands there might make sense (though
worth testing to be sure the right thing happens)
line 254, 263, Could we make these two options instead:
[--sync-actuators | --sync-actuators-timeout timeout]
--sync-actuators sets an infinite timeout
--sync-actuators-timeout sets a flexible timeout
Omission of either option uses the current asynchronous actuator to fire
and using both options together would be an invalid set of options.
line 86, introduces an extra blank line
line 503, worth a comment to say 0 means asynchronous
line 509, debug code?
Does this change to the client API warrant a new (compatible) API
version - I think it does (but would defer to Shawn's advice)
If so, then I think we need to update doc/client_api_versions.txt, line
106, 107 here, and any API consumers in the gate.
line 1694, can we update the docstring to say what act_timeout is, as
promised by line 1658
line 674, Can we check for a valid value here, raising an exception
otherwise? I know we have value-checks in src/modules/client/options.py
as well, but I didn't think API consumers used that code.
src/modules/smf.py, fix copyright
That's all I could spot.